review comments

dio · dio · commit 75a15373164a · 2018-07-21T04:38:11.000+07:00
Signed-off-by: Dhi Aurrahman &lt;dio@rockybars.com&gt;
diff --git a/docs/root/configuration/overview/v2_overview.rst b/docs/root/configuration/overview/v2_overview.rst
@@ -564,7 +564,7 @@ the shared ADS channel.
 Management Server Unreachability
 --------------------------------
 
-When Envoy instance loses connectivity with the management server, Envoy will latch on to
+When an Envoy instance loses connectivity with the management server, Envoy will latch on to
 the previous configuration while actively retrying in the background to reestablish the
 connection with the management server.
 
diff --git a/source/common/upstream/logical_dns_cluster.cc b/source/common/upstream/logical_dns_cluster.cc
@@ -35,10 +35,12 @@ LogicalDnsCluster::LogicalDnsCluster(const envoy::api::v2::Cluster& cluster,
                            : Config::Utility::translateClusterHosts(cluster.hosts())) {
   const auto& locality_lb_endpoints = load_assignment_.endpoints();
   if (locality_lb_endpoints.size() != 1 || locality_lb_endpoints[0].lb_endpoints().size() != 1) {
-    throw EnvoyException(fmt::format("LOGICAL_DNS clusters must have {}",
-                                     cluster.has_load_assignment()
-                                         ? "a single locality_lb_endpoint and a single lb_endpoint"
-                                         : "a single host"));
+    if (cluster.has_load_assignment()) {
+      throw EnvoyException(
+          "LOGICAL_DNS clusters must have a single locality_lb_endpoint and a single lb_endpoint");
+    } else {
+      throw EnvoyException("LOGICAL_DNS clusters must have a single host");
+    }
   }
 
   switch (cluster.dns_lookup_family()) {
