Add tests

dio · dio · commit 6c263d3ebd2d · 2018-08-13T11:01:31.000+07:00
Signed-off-by: Dhi Aurrahman &lt;dio@tetrate.io&gt;
diff --git a/test/integration/ads_integration_test.cc b/test/integration/ads_integration_test.cc
@@ -132,6 +132,10 @@ class AdsIntegrationTest : public AdsIntegrationBaseTest,
     envoy::api::v2::DiscoveryRequest discovery_request;
     VERIFY_ASSERTION(ads_stream_->waitForGrpcMessage(*dispatcher_, discovery_request));
 
+    ASSERT(discovery_request.has_node());
+    EXPECT_FALSE(discovery_request.node().id().empty());
+    EXPECT_FALSE(discovery_request.node().cluster().empty());
+
     // TODO(PiotrSikora): Remove this hack once fixed internally.
     if (!(expected_type_url == discovery_request.type_url())) {
       return AssertionFailure() << fmt::format("type_url {} does not match expected {}",
diff --git a/test/integration/load_stats_integration_test.cc b/test/integration/load_stats_integration_test.cc
@@ -164,6 +164,9 @@ class LoadStatsIntegrationTest : public HttpIntegrationTest,
       return;
     } else if (loadstats_request.cluster_stats_size() == 0) {
       loadstats_request.CopyFrom(local_loadstats_request);
+      ASSERT(loadstats_request.has_node());
+      EXPECT_FALSE(loadstats_request.node().id().empty());
+      EXPECT_FALSE(loadstats_request.node().cluster().empty());
       return;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -164,6 +164,9 @@ class LoadStatsIntegrationTest : public HttpIntegrationTest,`
`164`	`164`	`return;`
`165`	`165`	`} else if (loadstats_request.cluster_stats_size() == 0) {`
`166`	`166`	`loadstats_request.CopyFrom(local_loadstats_request);`
	`167`	`+ ASSERT(loadstats_request.has_node());`
	`168`	`+ EXPECT_FALSE(loadstats_request.node().id().empty());`
	`169`	`+ EXPECT_FALSE(loadstats_request.node().cluster().empty());`
`167`	`170`	`return;`
`168`	`171`	`}`
`169`	`172`