comments

Jose Nino · Jose Nino · commit 540a5aed80ed · 2020-08-07T10:19:44.000-07:00
Signed-off-by: Jose Nino &lt;jnino@lyft.com&gt;
diff --git a/source/extensions/filters/http/decompressor/decompressor_filter.cc b/source/extensions/filters/http/decompressor/decompressor_filter.cc
@@ -100,7 +100,10 @@ Http::FilterDataStatus DecompressorFilter::decodeData(Buffer::Instance& data, bo
 }
 
 Http::FilterTrailersStatus DecompressorFilter::decodeTrailers(Http::RequestTrailerMap& trailers) {
-  request_byte_tracker_.reportTotalBytes(trailers);
+  // Only report if the filter has actually decompressed.
+  if (request_decompressor_) {
+    request_byte_tracker_.reportTotalBytes(trailers);
+  }
   return Http::FilterTrailersStatus::Continue;
 }
 
@@ -129,7 +132,10 @@ Http::FilterDataStatus DecompressorFilter::encodeData(Buffer::Instance& data, bo
 }
 
 Http::FilterTrailersStatus DecompressorFilter::encodeTrailers(Http::ResponseTrailerMap& trailers) {
-  response_byte_tracker_.reportTotalBytes(trailers);
+  // Only report if the filter has actually decompressed.
+  if (response_decompressor_) {
+    response_byte_tracker_.reportTotalBytes(trailers);
+  }
   return Http::FilterTrailersStatus::Continue;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,10 @@ Http::FilterDataStatus DecompressorFilter::decodeData(Buffer::Instance& data, bo`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`Http::FilterTrailersStatus DecompressorFilter::decodeTrailers(Http::RequestTrailerMap& trailers) {`
`103`		`- request_byte_tracker_.reportTotalBytes(trailers);`
	`103`	`+ // Only report if the filter has actually decompressed.`
	`104`	`+ if (request_decompressor_) {`
	`105`	`+ request_byte_tracker_.reportTotalBytes(trailers);`
	`106`	`+ }`
`104`	`107`	`return Http::FilterTrailersStatus::Continue;`
`105`	`108`	`}`
`106`	`109`
`@@ -129,7 +132,10 @@ Http::FilterDataStatus DecompressorFilter::encodeData(Buffer::Instance& data, bo`
`129`	`132`	`}`
`130`	`133`
`131`	`134`	`Http::FilterTrailersStatus DecompressorFilter::encodeTrailers(Http::ResponseTrailerMap& trailers) {`
`132`		`- response_byte_tracker_.reportTotalBytes(trailers);`
	`135`	`+ // Only report if the filter has actually decompressed.`
	`136`	`+ if (response_decompressor_) {`
	`137`	`+ response_byte_tracker_.reportTotalBytes(trailers);`
	`138`	`+ }`
`133`	`139`	`return Http::FilterTrailersStatus::Continue;`
`134`	`140`	`}`
`135`	`141`