dns cache: remove assert at this layer (#18301)

goaway · web-flow · commit 0656e34e0c87 · 2021-09-28T20:12:05.000-06:00
Signed-off-by: Mike Schore &lt;mike.schore@gmail.com&gt;
diff --git a/source/extensions/common/dynamic_forward_proxy/dns_cache_manager_impl.cc b/source/extensions/common/dynamic_forward_proxy/dns_cache_manager_impl.cc
@@ -32,7 +32,6 @@ DnsCacheSharedPtr DnsCacheManagerImpl::getCache(
 }
 
 DnsCacheSharedPtr DnsCacheManagerImpl::lookUpCacheByName(absl::string_view cache_name) {
-  ASSERT(context_.mainThreadDispatcher().isThreadSafe());
   const auto& existing_cache = caches_.find(cache_name);
   if (existing_cache != caches_.end()) {
     return existing_cache->second.cache_;

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,6 @@ DnsCacheSharedPtr DnsCacheManagerImpl::getCache(`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`DnsCacheSharedPtr DnsCacheManagerImpl::lookUpCacheByName(absl::string_view cache_name) {`
`35`		`- ASSERT(context_.mainThreadDispatcher().isThreadSafe());`
`36`	`35`	`const auto& existing_cache = caches_.find(cache_name);`
`37`	`36`	`if (existing_cache != caches_.end()) {`
`38`	`37`	`return existing_cache->second.cache_;`