Conversation
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
requested review from
aabchoo,
missBerg and
wengyao04
as code owners
yuzisun
reviewed
Jan 11, 2025
yuzisun
reviewed
Jan 11, 2025
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Member
Author
|
Applied the change according to the discussion so far:
anything else? |
mathetake
changed the title
Member
Author
|
PING ALL - this is blocking others |
Contributor
|
LGTM |
Krishanx92
approved these changes
Jan 15, 2025
Member
Author
|
others thoughts? if not, I will polish this PR as a proper one not just for discussion |
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Member
Author
|
ok i will work on it |
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
changed the title
Member
Author
|
@yuzisun can you take a look? |
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
yuzisun
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes up in a thread in #71 with @yuzisun, and we might
want to remove the LLM prefix.
The rationale is that the current functionality is nothing to do
with "LLM" but more about the general routing and authn/z
with "AI providers" where the input is OpenAI format.
On the other hand, there "will be" the LLM specific CRD such
as the configurations for prompt guard, semantics caching etc.
I would like to have inputs from the community members!
cc @envoyproxy/ai-gateway-assignable