Skip to content

feat: implement aws credential file auth#161

Merged
mathetake merged 14 commits intomainfrom
aaron/auth-aws-credential-file
Jan 22, 2025
Merged

feat: implement aws credential file auth#161
mathetake merged 14 commits intomainfrom
aaron/auth-aws-credential-file

Conversation

@aabchoo
Copy link
Copy Markdown
Contributor

@aabchoo aabchoo commented Jan 22, 2025

Replace ENV AWS auth with credential file

@aabchoo aabchoo marked this pull request as ready for review January 22, 2025 21:22
@aabchoo aabchoo requested a review from a team as a code owner January 22, 2025 21:22
Copy link
Copy Markdown
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo nits!

aabchoo and others added 2 commits January 22, 2025 16:57
Co-authored-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Aaron Choo <[email protected]>
Co-authored-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Aaron Choo <[email protected]>
@mathetake
Copy link
Copy Markdown
Member

i found some bugs in the previous PR but i will fix it in the e2e addition

@mathetake mathetake merged commit 48f0a6a into main Jan 22, 2025
@mathetake mathetake deleted the aaron/auth-aws-credential-file branch January 22, 2025 22:02
mathetake added a commit that referenced this pull request Jan 29, 2025
**Commit Message**:

This adds a secret watcher controller that enables the 
hot reload of any secret referenced by backendTrafficPolicy.

**Related Issues/PRs (if applicable)**:

Follow up on #43  #106 #161 
Supersede #185

---------

Signed-off-by: Takeshi Yoneda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants