Add support for the developer role in chat completion messages#117
Add support for the developer role in chat completion messages#117yuzisun merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Ignasi Barrera <[email protected]>
|
thanks @nacx ! Can you help add a test? |
|
What kind of additional test do you mean? I already modified the unit test that unmarshals the request to make sure it it properly handled, so I think that should be enough for the scope of the change? I mean, by adding, say, an e2e test we would be jsu testing that the backend understands that |
|
How does it translated into Bedrock request ? In OpenAIMessageToBedrockMessage, if the role is |
fyi this is a bug in ci setting - i am working on it |
|
i think the existing unit test should be good. Now the question is how to translate this in aws bedrock request. Erring seems reasonable though |
|
leaving it as a TODO with a new issue would be good as well |
|
@nacx can you merge the main? I think we could merge as-is |
This is a follow-up PR for: #117 (comment) I think it makes sense to do the same conversions and set it as "system"? The "developer" role is a replacement for "system" in OpenAI, so it should be fine? Signed-off-by: Ignasi Barrera <[email protected]>
This is a follow-up PR for: #117 (comment) I think it makes sense to do the same conversions and set it as "system"? The "developer" role is a replacement for "system" in OpenAI, so it should be fine? Signed-off-by: Ignasi Barrera <[email protected]>
4 participants
With o1 models and newer,
developermessages replace the previoussystemmessages.