Conversation
In version 0.28` of `httpx`, the handling of GET query parameters has changed in a backwards-incompatible way. The new behaviour is to replace query parameters in the URL when parameters are passed via the `params` kwarg. Our pagination code expects that parameters in the URL get merged with the additional parameters of the `params` kwarg. This PR explicitly implements the old behaviour of merging params to fix compatibility with recent releases of `httpx`.
Coverage resultsThis is the coverage report for commit 517b6a3 |
denizs
approved these changes
Jan 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
httpx==0.28.0, the handling of GET query parameters has changed in a backwards-incompatible way. The new behaviour is to replace query parameters in the URL when parameters are passed via theparamskwarg. Our pagination code expects that parameters in the URL get merged with the additional parameters of theparamskwarg. This PR explicitly implements the old behaviour of merging params to fix compatibility with recent releases ofhttpx.refs: