Disallow flutter run-ing on 32-bit development devices (#97339)

jmagman · web-flow · commit 888208c1f4e0 · 2022-04-12T14:39:07.000-07:00
diff --git a/packages/flutter_tools/lib/src/ios/devices.dart b/packages/flutter_tools/lib/src/ios/devices.dart
@@ -302,7 +302,8 @@ class IOSDevice extends Device {
   }
 
   @override
-  bool isSupported() => true;
+  // 32-bit devices are not supported.
+  bool isSupported() => cpuArchitecture == DarwinArch.arm64;
 
   @override
   Future<LaunchResult> startApp(
diff --git a/packages/flutter_tools/test/general.shard/ios/devices_test.dart b/packages/flutter_tools/test/general.shard/ios/devices_test.dart
@@ -64,7 +64,7 @@ void main() {
     });
 
     testWithoutContext('successfully instantiates on Mac OS', () {
-      IOSDevice(
+      final IOSDevice device = IOSDevice(
         'device-123',
         iProxy: IProxy.test(logger: logger, processManager: FakeProcessManager.any()),
         fileSystem: fileSystem,
@@ -77,6 +77,23 @@ void main() {
         cpuArchitecture: DarwinArch.arm64,
         interfaceType: IOSDeviceConnectionInterface.usb,
       );
+      expect(device.isSupported(), isTrue);
+    });
+
+    testWithoutContext('32-bit devices are unsupported', () {
+      final IOSDevice device = IOSDevice(
+        'device-123',
+        iProxy: IProxy.test(logger: logger, processManager: FakeProcessManager.any()),
+        fileSystem: fileSystem,
+        logger: logger,
+        platform: macPlatform,
+        iosDeploy: iosDeploy,
+        iMobileDevice: iMobileDevice,
+        name: 'iPhone 1',
+        cpuArchitecture: DarwinArch.armv7,
+        interfaceType: IOSDeviceConnectionInterface.usb,
+      );
+      expect(device.isSupported(), isFalse);
     });
 
     testWithoutContext('parses major version', () {

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,8 @@ class IOSDevice extends Device {`
`302`	`302`	`}`
`303`	`303`
`304`	`304`	`@override`
`305`		`- bool isSupported() => true;`
	`305`	`+ // 32-bit devices are not supported.`
	`306`	`+ bool isSupported() => cpuArchitecture == DarwinArch.arm64;`
`306`	`307`
`307`	`308`	`@override`
`308`	`309`	`Future<LaunchResult> startApp(`