Repository navigation
Commit b61335b
authored
Fix DropdownMenu default width does not take label into account (#161219)
## Description
This PR fixes `DropdownMenu` default width when a long label is
provided.
Before:
The width is based on the longest menu item (which can be smaller than
the label):

After:
The width also depends on the label width when it is longer than the
menu items.

## Related Issue
Fixes [DropdownMenu default width does not take label into
account](flutter/flutter#136678)
## Tests
Adds 2 tests.1 parent 60d0bfc commit b61335b
2 files changed
Lines changed: 81 additions & 8 deletions
File tree
- packages/flutter
- lib/src/material
- test/material
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1079 | 1079 | | |
1080 | 1080 | | |
1081 | 1081 | | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
1082 | 1087 | | |
1083 | 1088 | | |
1084 | 1089 | | |
1085 | 1090 | | |
1086 | 1091 | | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
1087 | 1100 | | |
1088 | 1101 | | |
1089 | 1102 | | |
| |||
1317 | 1330 | | |
1318 | 1331 | | |
1319 | 1332 | | |
| 1333 | + | |
1320 | 1334 | | |
1321 | 1335 | | |
1322 | 1336 | | |
| 1337 | + | |
1323 | 1338 | | |
1324 | 1339 | | |
1325 | 1340 | | |
| |||
1344 | 1359 | | |
1345 | 1360 | | |
1346 | 1361 | | |
1347 | | - | |
| 1362 | + | |
1348 | 1363 | | |
1349 | 1364 | | |
1350 | 1365 | | |
1351 | | - | |
| 1366 | + | |
1352 | 1367 | | |
1353 | 1368 | | |
1354 | 1369 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
718 | 718 | | |
719 | 719 | | |
720 | 720 | | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
721 | 779 | | |
722 | 780 | | |
723 | 781 | | |
| |||
962 | 1020 | | |
963 | 1021 | | |
964 | 1022 | | |
965 | | - | |
| 1023 | + | |
966 | 1024 | | |
967 | 1025 | | |
968 | 1026 | | |
| |||
985 | 1043 | | |
986 | 1044 | | |
987 | 1045 | | |
988 | | - | |
| 1046 | + | |
989 | 1047 | | |
990 | 1048 | | |
991 | 1049 | | |
| |||
1009 | 1067 | | |
1010 | 1068 | | |
1011 | 1069 | | |
1012 | | - | |
| 1070 | + | |
1013 | 1071 | | |
1014 | 1072 | | |
1015 | 1073 | | |
| |||
1040 | 1098 | | |
1041 | 1099 | | |
1042 | 1100 | | |
1043 | | - | |
| 1101 | + | |
1044 | 1102 | | |
1045 | 1103 | | |
1046 | 1104 | | |
| |||
1072 | 1130 | | |
1073 | 1131 | | |
1074 | 1132 | | |
1075 | | - | |
| 1133 | + | |
1076 | 1134 | | |
1077 | 1135 | | |
1078 | 1136 | | |
| |||
1110 | 1168 | | |
1111 | 1169 | | |
1112 | 1170 | | |
1113 | | - | |
| 1171 | + | |
1114 | 1172 | | |
1115 | 1173 | | |
1116 | 1174 | | |
| |||
0 commit comments