Skip to content

Commit a82ae23

Browse files
Update labeler version, fix yaml to work with v5 (#139564)
This fixes flutter/flutter#139511 * A bug has been fixed with `sync-labels`, meaning this needs to be a boolean now. Setting to `true` to match v4 logic. * in `labeler.yml`, all labels must be a list of globs, so updated them all to be a list of `any`. * Update the version to v5 This is a little annoying to test, since the way github actions works means that changes to workflows aren't run until after they are merged. A workaround is I forked these labeler changes to a new branch in my own repo and created a PR to merge to that branch, seen here: https://github.com/drewroengoogle/flutter/actions/runs/7102118110/job/19331743809?pr=2. Note the step `Run actions/labeler@8558fd7` which ensures we are running on the latest labeler version in that check.
1 parent ea97fc4 commit a82ae23

2 files changed

Lines changed: 75 additions & 54 deletions

File tree

‎.github/labeler.yml‎

Lines changed: 73 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -4,95 +4,116 @@
44

55
# See https://github.com/actions/labeler/blob/main/README.md for docs.
66
'a: accessibility':
7-
- '**/accessibility/*'
8-
- '**/*accessibility*'
9-
- '**/semantics/*'
10-
- '**/*semantics*'
7+
- any:
8+
- '**/accessibility/*'
9+
- '**/*accessibility*'
10+
- '**/semantics/*'
11+
- '**/*semantics*'
1112

1213
'a: animation':
13-
- '**/animation/*'
14-
- '**/*animation*'
14+
- any:
15+
- '**/animation/*'
16+
- '**/*animation*'
1517

1618
'a: desktop':
17-
- '**/linux/**/*'
18-
- '**/macos/**/*'
19-
- '**/windows/**/*'
19+
- any:
20+
- '**/linux/**/*'
21+
- '**/macos/**/*'
22+
- '**/windows/**/*'
2023

2124
'a: internationalization':
22-
- packages/flutter_localizations/**/*
25+
- any:
26+
- packages/flutter_localizations/**/*
2327

2428
'a: tests':
25-
- packages/flutter_driver/**/*
26-
- packages/flutter_goldens/**/*
27-
- packages/flutter_goldens_client/**/*
28-
- packages/flutter_test/**/*
29+
- any:
30+
- packages/flutter_driver/**/*
31+
- packages/flutter_goldens/**/*
32+
- packages/flutter_goldens_client/**/*
33+
- packages/flutter_test/**/*
2934

3035
'a: text input':
31-
- '**/text/*'
32-
- '**/*text*'
36+
- any:
37+
- '**/text/*'
38+
- '**/*text*'
3339

3440
'd: api docs':
35-
- examples/api/**/*
41+
- any:
42+
- examples/api/**/*
3643

3744
'd: examples':
38-
- examples/**/*
45+
- any:
46+
- examples/**/*
3947

4048
engine:
41-
- bin/internal/engine.version
49+
- any:
50+
- bin/internal/engine.version
4251

4352
'f: cupertino':
44-
- '**/cupertino/*'
45-
- '**/*cupertino*'
53+
- any:
54+
- '**/cupertino/*'
55+
- '**/*cupertino*'
4656

4757
'f: focus':
48-
- '**/focus/*'
49-
- '**/*focus*'
58+
- any:
59+
- '**/focus/*'
60+
- '**/*focus*'
5061

5162
'f: gestures':
52-
- '**/gestures/*'
53-
- '**/*gestures*'
63+
- any:
64+
- '**/gestures/*'
65+
- '**/*gestures*'
5466

5567
'f: material design':
56-
- '**/material/*'
57-
- '**/*material*'
68+
- any:
69+
- '**/material/*'
70+
- '**/*material*'
5871

5972
'f: routes':
60-
- '**/navigator/*'
61-
- '**/*navigator*'
62-
- '**/route/*'
63-
- '**/*route*'
73+
- any:
74+
- '**/navigator/*'
75+
- '**/*navigator*'
76+
- '**/route/*'
77+
- '**/*route*'
6478

6579
'f: scrolling':
66-
- '**/*scroll*'
67-
- '**/scroll/*'
68-
- '**/*sliver*'
69-
- '**/sliver/*'
70-
- '**/*viewport*'
71-
- '**/viewport/*'
80+
- any:
81+
- '**/*scroll*'
82+
- '**/scroll/*'
83+
- '**/*sliver*'
84+
- '**/sliver/*'
85+
- '**/*viewport*'
86+
- '**/viewport/*'
7287

7388
framework:
74-
- packages/flutter/**/*
75-
- packages/flutter_driver/**/*
76-
- packages/flutter_goldens/**/*
77-
- packages/flutter_goldens_client/**/*
78-
- packages/flutter_test/**/*
79-
- packages/integration_test/**/*
80-
- examples/api/**/*
89+
- any:
90+
- packages/flutter/**/*
91+
- packages/flutter_driver/**/*
92+
- packages/flutter_goldens/**/*
93+
- packages/flutter_goldens_client/**/*
94+
- packages/flutter_test/**/*
95+
- packages/integration_test/**/*
96+
- examples/api/**/*
8197

8298
'f: integration_test':
83-
- packages/integration_test/**/*
99+
- any:
100+
- packages/integration_test/**/*
84101

85102
platform-ios:
86-
- packages/flutter_tools/lib/src/ios/**/*
103+
- any:
104+
- packages/flutter_tools/lib/src/ios/**/*
87105

88106
'customer: gallery':
89-
- examples/flutter_gallery/**/*
107+
- any:
108+
- examples/flutter_gallery/**/*
90109

91110
'c: tech-debt':
92-
- '**/fix_data.yaml'
93-
- '**/*.expect'
94-
- '**/*test_fixes*'
111+
- any:
112+
- '**/fix_data.yaml'
113+
- '**/*.expect'
114+
- '**/*test_fixes*'
95115

96116
tool:
97-
- packages/flutter_tools/**/*
98-
- packages/fuchsia_remote_debug_protocol/**/*
117+
- any:
118+
- packages/flutter_tools/**/*
119+
- packages/fuchsia_remote_debug_protocol/**/*

‎.github/workflows/labeler.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ jobs:
1717
runs-on: ubuntu-latest
1818
steps:
1919
# Source available at https://github.com/actions/labeler/blob/main/README.md
20-
- uses: actions/labeler@ac9175f8a1f3625fd0d4fb234536d26811351594
20+
- uses: actions/labeler@8558fd74291d67161a8a78ce36a881fa63b766a9
2121
with:
22-
sync-labels: ''
22+
sync-labels: true

0 commit comments

Comments
 (0)