Repository navigation
Commit 659d955
authored
[CP-beta][web] ClickDebouncer workaround for iOS Safari click behavior (#173072)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
### Issue Link:
What is the link to the issue this cherry-pick is addressing?
flutter/flutter#172180
### Changelog Description:
Fix a bug that causes the web engine to double report taps on dropdown menu items on iOS Safari.
### Impact Description:
It breaks Flutter Web apps that use dropdown menus with semantics enabled on iOS Safari.
### Workaround:
Is there a workaround for this issue?
No.
### Risk:
What is the risk level of this cherry-pick?
### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
### Validation Steps:
What are the steps to validate that this fix works?
Follow repro steps in flutter/flutter#1721801 parent 26b84dd commit 659d955
2 files changed
Lines changed: 136 additions & 28 deletions
File tree
- engine/src/flutter/lib/web_ui
- lib/src/engine
- test/engine
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
170 | | - | |
| 170 | + | |
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
| |||
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
224 | | - | |
| 224 | + | |
| 225 | + | |
225 | 226 | | |
226 | 227 | | |
227 | 228 | | |
| |||
245 | 246 | | |
246 | 247 | | |
247 | 248 | | |
248 | | - | |
| 249 | + | |
249 | 250 | | |
250 | 251 | | |
251 | 252 | | |
| |||
313 | 314 | | |
314 | 315 | | |
315 | 316 | | |
316 | | - | |
317 | | - | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
318 | 328 | | |
319 | 329 | | |
320 | 330 | | |
321 | 331 | | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
343 | 342 | | |
344 | 343 | | |
345 | 344 | | |
346 | 345 | | |
347 | 346 | | |
348 | 347 | | |
349 | 348 | | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
350 | 382 | | |
351 | 383 | | |
352 | | - | |
| 384 | + | |
353 | 385 | | |
354 | 386 | | |
355 | 387 | | |
| |||
394 | 426 | | |
395 | 427 | | |
396 | 428 | | |
397 | | - | |
| 429 | + | |
398 | 430 | | |
399 | 431 | | |
400 | 432 | | |
| |||
409 | 441 | | |
410 | 442 | | |
411 | 443 | | |
| 444 | + | |
412 | 445 | | |
413 | 446 | | |
414 | 447 | | |
| |||
428 | 461 | | |
429 | 462 | | |
430 | 463 | | |
| 464 | + | |
431 | 465 | | |
432 | 466 | | |
433 | 467 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2580 | 2580 | | |
2581 | 2581 | | |
2582 | 2582 | | |
| 2583 | + | |
| 2584 | + | |
| 2585 | + | |
| 2586 | + | |
2583 | 2587 | | |
2584 | 2588 | | |
2585 | 2589 | | |
| |||
2635 | 2639 | | |
2636 | 2640 | | |
2637 | 2641 | | |
| 2642 | + | |
2638 | 2643 | | |
2639 | 2644 | | |
2640 | 2645 | | |
| |||
2646 | 2651 | | |
2647 | 2652 | | |
2648 | 2653 | | |
| 2654 | + | |
| 2655 | + | |
| 2656 | + | |
| 2657 | + | |
| 2658 | + | |
| 2659 | + | |
| 2660 | + | |
| 2661 | + | |
| 2662 | + | |
| 2663 | + | |
| 2664 | + | |
| 2665 | + | |
| 2666 | + | |
| 2667 | + | |
| 2668 | + | |
| 2669 | + | |
| 2670 | + | |
| 2671 | + | |
| 2672 | + | |
| 2673 | + | |
| 2674 | + | |
| 2675 | + | |
| 2676 | + | |
| 2677 | + | |
| 2678 | + | |
| 2679 | + | |
| 2680 | + | |
| 2681 | + | |
| 2682 | + | |
| 2683 | + | |
| 2684 | + | |
| 2685 | + | |
| 2686 | + | |
| 2687 | + | |
| 2688 | + | |
| 2689 | + | |
| 2690 | + | |
| 2691 | + | |
| 2692 | + | |
| 2693 | + | |
| 2694 | + | |
| 2695 | + | |
| 2696 | + | |
| 2697 | + | |
| 2698 | + | |
| 2699 | + | |
| 2700 | + | |
| 2701 | + | |
| 2702 | + | |
| 2703 | + | |
| 2704 | + | |
| 2705 | + | |
| 2706 | + | |
| 2707 | + | |
| 2708 | + | |
| 2709 | + | |
| 2710 | + | |
| 2711 | + | |
| 2712 | + | |
| 2713 | + | |
| 2714 | + | |
| 2715 | + | |
| 2716 | + | |
| 2717 | + | |
| 2718 | + | |
2649 | 2719 | | |
2650 | 2720 | | |
2651 | 2721 | | |
| |||
2661 | 2731 | | |
2662 | 2732 | | |
2663 | 2733 | | |
| 2734 | + | |
2664 | 2735 | | |
2665 | 2736 | | |
2666 | 2737 | | |
| |||
2709 | 2780 | | |
2710 | 2781 | | |
2711 | 2782 | | |
| 2783 | + | |
2712 | 2784 | | |
2713 | 2785 | | |
2714 | 2786 | | |
| |||
2759 | 2831 | | |
2760 | 2832 | | |
2761 | 2833 | | |
| 2834 | + | |
2762 | 2835 | | |
2763 | 2836 | | |
2764 | 2837 | | |
| |||
2778 | 2851 | | |
2779 | 2852 | | |
2780 | 2853 | | |
| 2854 | + | |
2781 | 2855 | | |
2782 | 2856 | | |
2783 | 2857 | | |
| |||
0 commit comments