Skip to content

Commit 613a0ac

Browse files
authored
Implement SubmenuButton.onFocusChange (#139678)
Fixes #139409 `SubmenuButton.onFocusChange` is not implemented. This PR is just add one line fix to assign this property to `TextButton.onFocusChange` which is used in `SubmenuButton`:)
1 parent c22c19b commit 613a0ac

2 files changed

Lines changed: 38 additions & 0 deletions

File tree

‎packages/flutter/lib/src/material/menu_anchor.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1951,6 +1951,7 @@ class _SubmenuButtonState extends State<SubmenuButton> {
19511951
child: TextButton(
19521952
style: mergedStyle,
19531953
focusNode: _buttonFocusNode,
1954+
onFocusChange: _enabled ? widget.onFocusChange : null,
19541955
onHover: _enabled ? (bool hovering) => handleHover(hovering, context) : null,
19551956
onPressed: _enabled ? () => toggleShowMenu(context) : null,
19561957
isSemanticButton: null,

‎packages/flutter/test/material/menu_anchor_test.dart‎

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3519,6 +3519,43 @@ void main() {
35193519
expect(material.textStyle?.wordSpacing, menuTextStyle.wordSpacing);
35203520
expect(material.textStyle?.decoration, menuTextStyle.decoration);
35213521
});
3522+
3523+
testWidgetsWithLeakTracking('SubmenuButton.onFocusChange is respected', (WidgetTester tester) async {
3524+
final FocusNode focusNode = FocusNode();
3525+
int onFocusChangeCalled = 0;
3526+
await tester.pumpWidget(
3527+
MaterialApp(
3528+
home: Material(
3529+
child: StatefulBuilder(
3530+
builder: (BuildContext context, StateSetter setState) {
3531+
return SubmenuButton(
3532+
focusNode: focusNode,
3533+
onFocusChange: (bool value) {
3534+
setState(() {
3535+
onFocusChangeCalled += 1;
3536+
});
3537+
},
3538+
menuChildren: const <Widget>[
3539+
MenuItemButton(child: Text('item 0'))
3540+
],
3541+
child: const Text('Submenu 0'),
3542+
);
3543+
}
3544+
),
3545+
),
3546+
),
3547+
);
3548+
3549+
focusNode.requestFocus();
3550+
await tester.pump();
3551+
expect(focusNode.hasFocus, true);
3552+
expect(onFocusChangeCalled, 1);
3553+
3554+
focusNode.unfocus();
3555+
await tester.pump();
3556+
expect(focusNode.hasFocus, false);
3557+
expect(onFocusChangeCalled, 2);
3558+
});
35223559
}
35233560

35243561
List<Widget> createTestMenus({

0 commit comments

Comments
 (0)