Filter out FrameEvents/updateAcquireFence log spam from adb logcat (#179884)

shindonghwi · web-flow · commit 2b61b85c6699 · 2025-12-16T19:33:01.000Z
## Problem When using platform views like Google Maps on Android, the console gets flooded with messages like: ``` E/FrameEvents(26685): updateAcquireFence: Did not find frame. E/FrameEvents(26685): updateAcquireFence: Did not find frame. E/FrameEvents(26685): updateAcquireFence: Did not find frame. ... (repeats many times) ``` This makes it hard to see actual errors and warnings in the console. ## Cause This is a HWUI bug in Android, not an actual error. The message doesn't indicate any problem with the application. ## Fix Add a regex filter to `_filteredMessagees` in `AdbLogReader` to suppress these messages, following the same pattern used for similar spam messages like `SurfaceSyncer` and `ViewPostIme pointer`. ## Fixes flutter/flutter#104268 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
diff --git a/packages/flutter_tools/lib/src/android/android_device.dart b/packages/flutter_tools/lib/src/android/android_device.dart
@@ -1154,6 +1154,11 @@ class AdbLogReader extends DeviceLogReader {
     // Some versions of Android spew this out. It is inactionable to the end user
     // and causes no problems for the application.
     RegExp(r'^E/SurfaceSyncer\(\s*\d+\): Failed to find sync for id=\d+'),
+    // E/FrameEvents(26685): updateAcquireFence: Did not find frame.
+    // This is a HWUI bug that spams the console when using platform views like Google Maps.
+    // It is not an actual error and causes no problems for the application.
+    // See https://github.com/flutter/flutter/issues/104268
+    RegExp(r'^E/FrameEvents\(\s*\d+\): updateAcquireFence: Did not find frame\.$'),
     // See https://github.com/flutter/flutter/issues/160598
     RegExp(r'ViewPostIme pointer'),
     RegExp(r'mali.instrumentation.graph.work'),
diff --git a/packages/flutter_tools/test/general.shard/android/adb_log_reader_test.dart b/packages/flutter_tools/test/general.shard/android/adb_log_reader_test.dart
@@ -101,6 +101,38 @@ void main() {
     expect(emittedLines, const <String>['W/flutter($appPid): Hello there!']);
   });
 
+  // Regression test for https://github.com/flutter/flutter/issues/104268
+  testWithoutContext('AdbLogReader ignores spam from FrameEvents/updateAcquireFence', () async {
+    const appPid = 1;
+    final processManager = FakeProcessManager.list(<FakeCommand>[
+      FakeCommand(
+        command: const <String>['adb', '-s', '1234', 'shell', '-x', 'logcat', '-v', 'time'],
+        completer: Completer<void>.sync(),
+        stdout:
+            '$kDummyLine'
+            '05-11 12:54:46.665 W/flutter($appPid): Hello there!\n'
+            '05-11 12:54:46.665 E/FrameEvents($appPid): updateAcquireFence: Did not find frame.\n'
+            '05-11 12:54:46.666 E/FrameEvents($appPid): updateAcquireFence: Did not find frame.\n'
+            '05-11 12:54:46.667 E/FrameEvents($appPid): updateAcquireFence: Did not find frame.\n',
+      ),
+    ]);
+    final AdbLogReader logReader = await AdbLogReader.createLogReader(
+      createFakeDevice(null),
+      processManager,
+      BufferLogger.test(),
+    );
+    await logReader.provideVmService(_FakeFlutterVmService(appPid));
+    final onDone = Completer<void>.sync();
+    final emittedLines = <String>[];
+    logReader.logLines.listen((String line) {
+      emittedLines.add(line);
+    }, onDone: onDone.complete);
+    await null;
+    logReader.dispose();
+    await onDone.future;
+    expect(emittedLines, const <String>['W/flutter($appPid): Hello there!']);
+  });
+
   testWithoutContext('AdbLogReader calls adb logcat with expected flags apiVersion 21', () async {
     final processManager = FakeProcessManager.list(<FakeCommand>[
       const FakeCommand(
