Skip to content

Commit f2f1c28

Browse files
authored
Enable Built-in Kotlin for interactive_media_ads (flutter#12912)
Enables `android.builtInKotlin=true` for the `interactive_media_ads` plugin example app. Split out of flutter#12883, which flips the same flag for every other Android example app. This package was held back because it is the only one that needs an accompanying dependency change. Partially Addresses flutter#189235 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent e4ade63 commit f2f1c28

7 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎packages/interactive_media_ads/CHANGELOG.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
## NEXT
1+
## 0.3.0+18
22

3+
* Fixes unit test compilation when the Android build uses AGP's built-in Kotlin support.
34
* Updates minimum supported SDK version to Flutter 3.41/Dart 3.11.
45

56
## 0.3.0+17

‎packages/interactive_media_ads/android/build.gradle.kts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,7 @@ android {
4949
implementation("androidx.annotation:annotation:1.10.0")
5050
implementation("androidx.core:core-ktx:1.18.0")
5151
implementation("com.google.ads.interactivemedia.v3:interactivemedia:3.39.0")
52-
testImplementation("junit:junit:4.13.2")
53-
testImplementation("org.jetbrains.kotlin:kotlin-test")
52+
testImplementation("org.jetbrains.kotlin:kotlin-test-junit5:2.3.0")
5453
testImplementation("org.mockito.kotlin:mockito-kotlin:6.2.3")
5554
testImplementation("org.mockito:mockito-inline:5.2.0")
5655
testImplementation("androidx.test:core:1.7.0")

‎packages/interactive_media_ads/android/src/main/kotlin/dev/flutter/packages/interactive_media_ads/AdsRequestProxyApi.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class AdsRequestProxyApi(override val pigeonRegistrar: ProxyApiRegistrar) :
2121
*
2222
* This must match the version in pubspec.yaml.
2323
*/
24-
const val pluginVersion = "0.3.0+17"
24+
const val pluginVersion = "0.3.0+18"
2525
}
2626

2727
override fun setAdTagUrl(pigeon_instance: AdsRequest, adTagUrl: String) {

‎packages/interactive_media_ads/android/src/test/kotlin/dev/flutter/packages/interactive_media_ads/BaseManagerProxyApiTest.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import com.google.ads.interactivemedia.v3.api.AdEvent
1010
import com.google.ads.interactivemedia.v3.api.AdProgressInfo
1111
import com.google.ads.interactivemedia.v3.api.AdsRenderingSettings
1212
import com.google.ads.interactivemedia.v3.api.BaseManager
13-
import junit.framework.TestCase.assertEquals
1413
import kotlin.test.Test
14+
import kotlin.test.assertEquals
1515
import org.mockito.kotlin.mock
1616
import org.mockito.kotlin.verify
1717
import org.mockito.kotlin.whenever

‎packages/interactive_media_ads/example/android/gradle.properties‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ org.gradle.jvmargs=-Xmx4G -XX:+HeapDumpOnOutOfMemoryError
22
android.useAndroidX=true
33

44
# This builtInKotlin flag was added automatically by Flutter migrator
5-
android.builtInKotlin=false
5+
android.builtInKotlin=true
66
# This newDsl flag was added automatically by Flutter migrator
77
android.newDsl=false

‎packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsRequestProxyAPIDelegate.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class AdsRequestProxyAPIDelegate: PigeonApiDelegateIMAAdsRequest {
1313
/// The current version of the `interactive_media_ads` plugin.
1414
///
1515
/// This must match the version in pubspec.yaml.
16-
static let pluginVersion = "0.3.0+17"
16+
static let pluginVersion = "0.3.0+18"
1717

1818
func pigeonDefaultConstructor(
1919
pigeonApi: PigeonApiIMAAdsRequest, adTagUrl: String, adDisplayContainer: IMAAdDisplayContainer,

‎packages/interactive_media_ads/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: interactive_media_ads
22
description: A Flutter plugin for using the Interactive Media Ads SDKs on Android and iOS.
33
repository: https://github.com/flutter/packages/tree/main/packages/interactive_media_ads
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+interactive_media_ads%22
5-
version: 0.3.0+17 # This must match the version in
5+
version: 0.3.0+18 # This must match the version in
66
# `android/src/main/kotlin/dev/flutter/packages/interactive_media_ads/AdsRequestProxyApi.kt` and
77
# `ios/interactive_media_ads/Sources/interactive_media_ads/AdsRequestProxyAPIDelegate.swift`
88

0 commit comments

Comments
 (0)