Skip to content

Commit e310320

Browse files
authored
[web] Adds Noto Serif Tibetan fallback font. (flutter#52971)
This PR adds the "Noto Serif Tibetan" fallback font to Flutter Web, so it can render Dzongkha, and other languages in Tibetan script. (In order to add this fallback font, an automated script is run which updates the versions and glyphs of other fallback fonts at the same time) (Bundle uploaded to CIPD) ## Issues * Fixes flutter#148797 ## Testing * Added unit test for font resolution with sample text * Manually, in localhost, using the sample Dzongkha test from the Noto site: <img width="959" alt="Screenshot 2024-05-21 at 2 01 19�PM" src="https://github.com/flutter/engine/assets/1255594/3f2db34d-c004-4b90-9fda-62a9cff817f9"> ``` �ེ�ཡ�� འ����ླི������ི��ི���ེ�����ྲ���ྲི�ས� �ེ�ལས��ལ������ུ��ི���ི�འ�ྱ����ོ��ོ��ེ� ``` [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent eaaf1ef commit e310320

4 files changed

Lines changed: 1162 additions & 1086 deletions

File tree

‎DEPS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1029,7 +1029,7 @@ deps = {
10291029
'packages': [
10301030
{
10311031
'package': 'flutter/flutter_font_fallbacks',
1032-
'version': '14d38cffa1a2c9d4380094957aa63aee811b613b0dc53fd909557f61f6a9068c'
1032+
'version': '6126aab94a469ad17de6c170885b8dee8e8283cfd2383c4c77cf54c702374981'
10331033
}
10341034
],
10351035
'dep_type': 'cipd',

‎lib/web_ui/dev/roll_fallback_fonts.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -473,6 +473,7 @@ const List<String> fallbackFonts = <String>[
473473
'Noto Sans Warang Citi',
474474
'Noto Sans Yi',
475475
'Noto Sans Zanabazar Square',
476+
'Noto Serif Tibetan',
476477
];
477478

478479
bool _checkForLicenseAttribution(Uint8List fontBytes) {

0 commit comments

Comments
 (0)