Repository navigation
Commit db43d9f
authored
[webview_flutter_wkwebview] Regenerate with pigeon 29.0.4 (flutter#12923)
## Description
Regenerates `webview_flutter_wkwebview` with pigeon `29.0.2`, which contains the Swift generator fix from flutter/packages#12531.
The generated `WKNavigationDelegate.didReceiveAuthenticationChallenge` reply handler now treats `NSNull` as a null reply, so a response the native `PigeonInstanceManager` can no longer resolve reports a `null-error` instead of force-casting and aborting the process:
```
Could not cast value of type 'NSNull' (0x...) to 'webview_flutter_wkwebview.AuthenticationChallengeResponse' (0x...).
```
The diff is large because the package was last generated with `27.3.2`, so it also picks up the `28.x`/`29.x` generator changes; no hand-written code needed updating.
## Verification
* `flutter analyze` is clean.
* All 154 unit tests pass.
* The iOS example builds for the simulator.
* The `NSNull` check is present at the `AuthenticationChallengeResponse` call site in the regenerated `WebKitLibrary.g.swift`.
*Fixes flutter#191254
## Pre-Review Checklist1 parent 5ef4d9e commit db43d9f
4 files changed
Lines changed: 13 additions & 11 deletions
File tree
- packages/webview_flutter/webview_flutter_wkwebview
- darwin/webview_flutter_wkwebview/Sources/webview_flutter_wkwebview
- lib/src/common
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
4430 | 4430 | | |
4431 | 4431 | | |
4432 | 4432 | | |
4433 | | - | |
| 4433 | + | |
4434 | 4434 | | |
4435 | 4435 | | |
4436 | 4436 | | |
| |||
4484 | 4484 | | |
4485 | 4485 | | |
4486 | 4486 | | |
4487 | | - | |
| 4487 | + | |
4488 | 4488 | | |
4489 | 4489 | | |
4490 | 4490 | | |
| |||
4669 | 4669 | | |
4670 | 4670 | | |
4671 | 4671 | | |
4672 | | - | |
| 4672 | + | |
4673 | 4673 | | |
4674 | 4674 | | |
4675 | 4675 | | |
| |||
6457 | 6457 | | |
6458 | 6458 | | |
6459 | 6459 | | |
6460 | | - | |
| 6460 | + | |
6461 | 6461 | | |
6462 | 6462 | | |
6463 | 6463 | | |
| |||
6556 | 6556 | | |
6557 | 6557 | | |
6558 | 6558 | | |
6559 | | - | |
| 6559 | + | |
6560 | 6560 | | |
6561 | 6561 | | |
6562 | 6562 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
0 commit comments