Skip to content

Commit db43d9f

Browse files
authored
[webview_flutter_wkwebview] Regenerate with pigeon 29.0.4 (flutter#12923)
## Description Regenerates `webview_flutter_wkwebview` with pigeon `29.0.2`, which contains the Swift generator fix from flutter/packages#12531. The generated `WKNavigationDelegate.didReceiveAuthenticationChallenge` reply handler now treats `NSNull` as a null reply, so a response the native `PigeonInstanceManager` can no longer resolve reports a `null-error` instead of force-casting and aborting the process: ``` Could not cast value of type 'NSNull' (0x...) to 'webview_flutter_wkwebview.AuthenticationChallengeResponse' (0x...). ``` The diff is large because the package was last generated with `27.3.2`, so it also picks up the `28.x`/`29.x` generator changes; no hand-written code needed updating. ## Verification * `flutter analyze` is clean. * All 154 unit tests pass. * The iOS example builds for the simulator. * The `NSNull` check is present at the `AuthenticationChallengeResponse` call site in the regenerated `WebKitLibrary.g.swift`. *Fixes flutter#191254 ## Pre-Review Checklist
1 parent 5ef4d9e commit db43d9f

4 files changed

Lines changed: 13 additions & 11 deletions

File tree

‎packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
## NEXT
1+
## 3.26.2
22

3+
* Fixes a crash when a `WKNavigationDelegate` authentication challenge reply cannot be
4+
resolved to a native instance.
35
* Updates minimum supported SDK version to Flutter 3.41/Dart 3.11.
46

57
## 3.26.1

‎packages/webview_flutter/webview_flutter_wkwebview/darwin/webview_flutter_wkwebview/Sources/webview_flutter_wkwebview/WebKitLibrary.g.swift‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright 2013 The Flutter Authors
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
4-
// Autogenerated from Pigeon (v27.3.2), do not edit directly.
4+
// Autogenerated from Pigeon (v29.0.4), do not edit directly.
55
// See also: https://pub.dev/packages/pigeon
66

77
import Foundation
@@ -33,7 +33,7 @@ final class PigeonError: Error {
3333

3434
var localizedDescription: String {
3535
return
36-
"PigeonError(code: \(code), message: \(message ?? "<nil>"), details: \(details ?? "<nil>")"
36+
"PigeonError(code: \(code), message: \(message ?? "<nil>"), details: \(details ?? "<nil>"))"
3737
}
3838
}
3939

@@ -4430,7 +4430,7 @@ final class PigeonApiWKNavigationDelegate: PigeonApiProtocolWKNavigationDelegate
44304430
let message: String? = nilOrValue(listResponse[1])
44314431
let details: String? = nilOrValue(listResponse[2])
44324432
completion(.failure(PigeonError(code: code, message: message, details: details)))
4433-
} else if listResponse[0] == nil {
4433+
} else if WebKitLibraryPigeonInternal.isNullish(listResponse[0]) {
44344434
completion(
44354435
.failure(
44364436
PigeonError(
@@ -4484,7 +4484,7 @@ final class PigeonApiWKNavigationDelegate: PigeonApiProtocolWKNavigationDelegate
44844484
let message: String? = nilOrValue(listResponse[1])
44854485
let details: String? = nilOrValue(listResponse[2])
44864486
completion(.failure(PigeonError(code: code, message: message, details: details)))
4487-
} else if listResponse[0] == nil {
4487+
} else if WebKitLibraryPigeonInternal.isNullish(listResponse[0]) {
44884488
completion(
44894489
.failure(
44904490
PigeonError(
@@ -4669,7 +4669,7 @@ final class PigeonApiWKNavigationDelegate: PigeonApiProtocolWKNavigationDelegate
46694669
let message: String? = nilOrValue(listResponse[1])
46704670
let details: String? = nilOrValue(listResponse[2])
46714671
completion(.failure(PigeonError(code: code, message: message, details: details)))
4672-
} else if listResponse[0] == nil {
4672+
} else if WebKitLibraryPigeonInternal.isNullish(listResponse[0]) {
46734673
completion(
46744674
.failure(
46754675
PigeonError(
@@ -6457,7 +6457,7 @@ final class PigeonApiWKUIDelegate: PigeonApiProtocolWKUIDelegate {
64576457
let message: String? = nilOrValue(listResponse[1])
64586458
let details: String? = nilOrValue(listResponse[2])
64596459
completion(.failure(PigeonError(code: code, message: message, details: details)))
6460-
} else if listResponse[0] == nil {
6460+
} else if WebKitLibraryPigeonInternal.isNullish(listResponse[0]) {
64616461
completion(
64626462
.failure(
64636463
PigeonError(
@@ -6556,7 +6556,7 @@ final class PigeonApiWKUIDelegate: PigeonApiProtocolWKUIDelegate {
65566556
let message: String? = nilOrValue(listResponse[1])
65576557
let details: String? = nilOrValue(listResponse[2])
65586558
completion(.failure(PigeonError(code: code, message: message, details: details)))
6559-
} else if listResponse[0] == nil {
6559+
} else if WebKitLibraryPigeonInternal.isNullish(listResponse[0]) {
65606560
completion(
65616561
.failure(
65626562
PigeonError(

‎packages/webview_flutter/webview_flutter_wkwebview/lib/src/common/web_kit.g.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright 2013 The Flutter Authors
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
4-
// Autogenerated from Pigeon (v27.3.2), do not edit directly.
4+
// Autogenerated from Pigeon (v29.0.4), do not edit directly.
55
// See also: https://pub.dev/packages/pigeon
66
// ignore_for_file: unused_import, unused_shown_name
77
// ignore_for_file: type=lint

‎packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: webview_flutter_wkwebview
22
description: A Flutter plugin that provides a WebView widget based on Apple's WKWebView control.
33
repository: https://github.com/flutter/packages/tree/main/packages/webview_flutter/webview_flutter_wkwebview
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22
5-
version: 3.26.1
5+
version: 3.26.2
66

77
environment:
88
sdk: ^3.12.0
@@ -33,7 +33,7 @@ dev_dependencies:
3333
flutter_test:
3434
sdk: flutter
3535
mockito: ^5.4.4
36-
pigeon: ^27.3.2
36+
pigeon: ^29.0.4
3737

3838
topics:
3939
- html

0 commit comments

Comments
 (0)