@@ -33,23 +33,23 @@ BufferView Command::GetVertexBuffer() const {
3333bool Command::BindResource (ShaderStage stage,
3434 const ShaderUniformSlot& slot,
3535 const ShaderMetadata& metadata,
36- const BufferView& view) {
37- return DoBindResource (stage, slot, &metadata, view);
36+ BufferView view) {
37+ return DoBindResource (stage, slot, &metadata, std::move ( view) );
3838}
3939
4040bool Command::BindResource (
4141 ShaderStage stage,
4242 const ShaderUniformSlot& slot,
4343 const std::shared_ptr<const ShaderMetadata>& metadata,
44- const BufferView& view) {
45- return DoBindResource (stage, slot, metadata, view);
44+ BufferView view) {
45+ return DoBindResource (stage, slot, metadata, std::move ( view) );
4646}
4747
4848template <class T >
4949bool Command::DoBindResource (ShaderStage stage,
5050 const ShaderUniformSlot& slot,
5151 const T metadata,
52- const BufferView& view) {
52+ BufferView view) {
5353 FML_DCHECK (slot.ext_res_0 != VertexDescriptor::kReservedVertexBufferIndex );
5454 if (!view) {
5555 return false ;
@@ -58,11 +58,11 @@ bool Command::DoBindResource(ShaderStage stage,
5858 switch (stage) {
5959 case ShaderStage::kVertex :
6060 vertex_bindings.buffers [slot.ext_res_0 ] = {
61- .slot = slot, .view = BufferResource (metadata, view)};
61+ .slot = slot, .view = BufferResource (metadata, std::move ( view) )};
6262 return true ;
6363 case ShaderStage::kFragment :
6464 fragment_bindings.buffers [slot.ext_res_0 ] = {
65- .slot = slot, .view = BufferResource (metadata, view)};
65+ .slot = slot, .view = BufferResource (metadata, std::move ( view) )};
6666 return true ;
6767 case ShaderStage::kCompute :
6868 VALIDATION_LOG << " Use ComputeCommands for compute shader stages." ;
@@ -78,8 +78,8 @@ bool Command::DoBindResource(ShaderStage stage,
7878bool Command::BindResource (ShaderStage stage,
7979 const SampledImageSlot& slot,
8080 const ShaderMetadata& metadata,
81- const std::shared_ptr<const Texture>& texture,
82- const std::shared_ptr<const Sampler>& sampler) {
81+ std::shared_ptr<const Texture> texture,
82+ std::shared_ptr<const Sampler> sampler) {
8383 if (!sampler || !sampler->IsValid ()) {
8484 return false ;
8585 }
@@ -94,15 +94,15 @@ bool Command::BindResource(ShaderStage stage,
9494 case ShaderStage::kVertex :
9595 vertex_bindings.sampled_images [slot.sampler_index ] = TextureAndSampler{
9696 .slot = slot,
97- .texture = {&metadata, texture},
98- .sampler = {&metadata, sampler},
97+ .texture = {&metadata, std::move ( texture) },
98+ .sampler = {&metadata, std::move ( sampler) },
9999 };
100100 return true ;
101101 case ShaderStage::kFragment :
102102 fragment_bindings.sampled_images [slot.sampler_index ] = TextureAndSampler{
103103 .slot = slot,
104- .texture = {&metadata, texture},
105- .sampler = {&metadata, sampler},
104+ .texture = {&metadata, std::move ( texture) },
105+ .sampler = {&metadata, std::move ( sampler) },
106106 };
107107 return true ;
108108 case ShaderStage::kCompute :
0 commit comments