Skip to content

Commit c9d051d

Browse files
authored
[material_ui] Remove unused parameters from constructors of generic classes. (flutter#12458)
We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes. This is work towards dart-lang/sdk#47839. ## Pre-Review Checklist Test exempt, as this code is covered by existing static and runtime checks.
1 parent 71f2b70 commit c9d051d

6 files changed

Lines changed: 5 additions & 20 deletions

File tree

‎packages/material_ui/lib/src/autocomplete.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,6 @@ class _AutocompleteField extends StatelessWidget {
226226
// The default Material-style Autocomplete options.
227227
class _AutocompleteOptions<T extends Object> extends StatelessWidget {
228228
const _AutocompleteOptions({
229-
super.key,
230229
required this.displayStringForOption,
231230
required this.onSelected,
232231
required this.openDirection,

‎packages/material_ui/lib/src/bottom_sheet.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -648,7 +648,6 @@ class _RenderBottomSheetLayoutWithSizeListener extends RenderShiftedBox {
648648

649649
class _ModalBottomSheet<T> extends StatefulWidget {
650650
const _ModalBottomSheet({
651-
super.key,
652651
required this.route,
653652
this.backgroundColor,
654653
this.elevation,

‎packages/material_ui/lib/src/dropdown.dart‎

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ class _DropdownMenuPainter extends CustomPainter {
110110
// The widget that is the button wrapping the menu items.
111111
class _DropdownMenuItemButton<T> extends StatefulWidget {
112112
const _DropdownMenuItemButton({
113-
super.key,
114113
this.padding,
115114
required this.route,
116115
required this.buttonRect,
@@ -249,7 +248,6 @@ class _DropdownMenuItemButtonState<T> extends State<_DropdownMenuItemButton<T>>
249248

250249
class _DropdownMenu<T> extends StatefulWidget {
251250
const _DropdownMenu({
252-
super.key,
253251
this.padding,
254252
required this.route,
255253
required this.buttonRect,
@@ -258,7 +256,6 @@ class _DropdownMenu<T> extends StatefulWidget {
258256
required this.enableFeedback,
259257
this.borderRadius,
260258
required this.scrollController,
261-
this.menuWidth,
262259
this.mouseCursor,
263260
});
264261

@@ -270,7 +267,6 @@ class _DropdownMenu<T> extends StatefulWidget {
270267
final bool enableFeedback;
271268
final BorderRadius? borderRadius;
272269
final ScrollController scrollController;
273-
final double? menuWidth;
274270
final MouseCursor? mouseCursor;
275271

276272
@override
@@ -649,7 +645,6 @@ class _DropdownRoute<T> extends PopupRoute<_DropdownRouteResult<T>> {
649645

650646
class _DropdownRoutePage<T> extends StatefulWidget {
651647
const _DropdownRoutePage({
652-
super.key,
653648
required this.route,
654649
required this.constraints,
655650
this.items,
@@ -758,7 +753,7 @@ class _DropdownRoutePageState<T> extends State<_DropdownRoutePage<T>> {
758753
// selected item lines up with the vertical center of the dropdown button,
759754
// as closely as possible.
760755
class _MenuItem<T> extends SingleChildRenderObjectWidget {
761-
const _MenuItem({super.key, required this.onLayout, required this.item}) : super(child: item);
756+
const _MenuItem({required this.onLayout, required this.item}) : super(child: item);
762757

763758
final ValueChanged<Size> onLayout;
764759
final DropdownMenuItem<T>? item;
@@ -1054,7 +1049,6 @@ class DropdownButton<T> extends StatefulWidget {
10541049
_isEmpty = false;
10551050

10561051
DropdownButton._formField({
1057-
super.key,
10581052
required this.items,
10591053
this.selectedItemBuilder,
10601054
this.value,
@@ -1064,15 +1058,13 @@ class DropdownButton<T> extends StatefulWidget {
10641058
this.onTap,
10651059
this.elevation = 8,
10661060
this.style,
1067-
this.underline,
10681061
this.icon,
10691062
this.iconDisabledColor,
10701063
this.iconEnabledColor,
10711064
this.iconSize = 24.0,
10721065
this.isDense = false,
10731066
this.isExpanded = false,
10741067
this.itemHeight = kMinInteractiveDimension,
1075-
this.menuWidth,
10761068
this.focusColor,
10771069
this.focusNode,
10781070
this.autofocus = false,
@@ -1087,7 +1079,9 @@ class DropdownButton<T> extends StatefulWidget {
10871079
this.dropdownMenuItemMouseCursor,
10881080
required this._inputDecoration,
10891081
required this._isEmpty,
1090-
}) : assert(
1082+
}) : underline = null,
1083+
menuWidth = null,
1084+
assert(
10911085
items == null ||
10921086
items.isEmpty ||
10931087
value == null ||

‎packages/material_ui/lib/src/popup_menu.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,6 @@ class _CheckedPopupMenuItemState<T> extends PopupMenuItemState<T, CheckedPopupMe
674674

675675
class _PopupMenu<T> extends StatefulWidget {
676676
const _PopupMenu({
677-
super.key,
678677
required this.itemKeys,
679678
required this.route,
680679
required this.semanticLabel,

‎packages/material_ui/lib/src/segmented_button.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -737,7 +737,6 @@ class SegmentedButtonState<T> extends State<SegmentedButton<T>> {
737737

738738
class _SegmentedButtonRenderWidget<T> extends MultiChildRenderObjectWidget {
739739
const _SegmentedButtonRenderWidget({
740-
super.key,
741740
required this.segments,
742741
required this.enabledBorder,
743742
required this.disabledBorder,

‎packages/material_ui/test/scaffold_test.dart‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3877,12 +3877,7 @@ class _GeometryCachePainter extends CustomPainter {
38773877
}
38783878

38793879
class _CustomPageRoute<T> extends PageRoute<T> {
3880-
_CustomPageRoute({
3881-
required this.builder,
3882-
RouteSettings super.settings = const RouteSettings(),
3883-
this.maintainState = true,
3884-
super.fullscreenDialog,
3885-
});
3880+
_CustomPageRoute({required this.builder, this.maintainState = true, super.fullscreenDialog});
38863881

38873882
final WidgetBuilder builder;
38883883

0 commit comments

Comments
 (0)