Repository navigation
Commit bf02f34
authored
Update ci for + releases (flutter#12419)
Updates the `enabled_branches` regex patterns in `.ci.yaml` to support SemVer release branch names with optional pre-release tags (e.g., `-dev.1`) and build metadata suffixes (e.g., `+1`).
Previously, `enabled_branches` used the strict pattern `release-<package>-\d+\.\d+\.\d+`.
When release branches were created with build metadata suffixes (e.g., `release-material_ui-0.0.3+1`), Cocoon CI failed validation with:
> `release-material_ui-0.0.3+1 is not enabled for this .ci.yaml. Add it to run tests against this PR.`
Blocked PRs:
- flutter/packages#12412
- flutter/packages#12410
Updated the regex for release branches to `release-<package>-\d+\.\d+\.\d+(?:-[\w.]+)?(?:\+[\w.]+)?`, allowing valid SemVer pre-release and build metadata identifiers while maintaining strict matching against non-version branch names.
### Pattern Verification Examples
| Branch Name | Match Result | Status |
| --- | --- | --- |
| `release-material_ui-0.0.3` | **Match** | ✅ Standard SemVer |
| `release-material_ui-0.0.3+1` | **Match** | ✅ Build metadata suffix |
| `release-material_ui-0.0.3-dev.1+2` | **Match** | ✅ Pre-release & build metadata |
| `release-material_ui-invalid-branch` | **No Match** | ❌ Rejected |
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.1 parent 19a9f91 commit bf02f34
3 files changed
Lines changed: 12 additions & 10 deletions
File tree
- script/tool
- lib/src/validators
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
12 | | - | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
403 | 403 | | |
404 | 404 | | |
405 | 405 | | |
406 | | - | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
407 | 409 | | |
408 | 410 | | |
409 | 411 | | |
410 | | - | |
| 412 | + | |
411 | 413 | | |
412 | 414 | | |
413 | 415 | | |
414 | 416 | | |
415 | 417 | | |
416 | 418 | | |
417 | | - | |
| 419 | + | |
418 | 420 | | |
419 | 421 | | |
420 | 422 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
696 | 696 | | |
697 | 697 | | |
698 | 698 | | |
699 | | - | |
| 699 | + | |
700 | 700 | | |
701 | 701 | | |
702 | 702 | | |
| |||
991 | 991 | | |
992 | 992 | | |
993 | 993 | | |
994 | | - | |
| 994 | + | |
995 | 995 | | |
996 | 996 | | |
997 | 997 | | |
| |||
1006 | 1006 | | |
1007 | 1007 | | |
1008 | 1008 | | |
1009 | | - | |
| 1009 | + | |
1010 | 1010 | | |
1011 | 1011 | | |
1012 | 1012 | | |
| |||
1023 | 1023 | | |
1024 | 1024 | | |
1025 | 1025 | | |
1026 | | - | |
| 1026 | + | |
1027 | 1027 | | |
1028 | 1028 | | |
1029 | 1029 | | |
| |||
0 commit comments