Skip to content

Commit b48550d

Browse files
[cupertino_ui] Unskip web tests that pass on CanvasKit and Skwasm: nav_bar_transition_test, refresh_test, route_test, text_field_cursor_test (flutter#13439)
Removes the whole-file `@TestOn('!chrome')` annotations from four `cupertino_ui` test files so they run on the web: - `nav_bar_transition_test.dart` - `refresh_test.dart` - `route_test.dart` (keeps the existing targeted web skip on the state restoration test) - `text_field_cursor_test.dart` All of the newly enabled tests pass on Chrome under both CI web renderers: CanvasKit (`flutter test --platform chrome`) and Skwasm (`flutter test --platform chrome --wasm`). None of them use golden files. Leaving the skips in place hides web regressions in these widgets. Part of flutter#33615 (the original web limitation behind these skips is closed; the one test that still depends on state restoration stays skipped on web). This is a test-only change, so it is exempt from version and CHANGELOG updates. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 3ada763 commit b48550d

4 files changed

Lines changed: 0 additions & 8 deletions

File tree

‎packages/cupertino_ui/test/nav_bar_transition_test.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
// This file is run as part of a reduced test set in CI on Mac and Windows
66
// machines.
77
@Tags(<String>['reduced-test-set'])
8-
@TestOn('!chrome')
98
library;
109

1110
import 'dart:async' show unawaited;

‎packages/cupertino_ui/test/refresh_test.dart‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
@TestOn('!chrome')
6-
library;
7-
85
import 'dart:async';
96

107
import 'package:cupertino_ui/cupertino_ui.dart';

‎packages/cupertino_ui/test/route_test.dart‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
@TestOn('!chrome')
6-
library;
7-
85
import 'dart:async';
96
import 'dart:ui';
107

‎packages/cupertino_ui/test/text_field_cursor_test.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
// This file is run as part of a reduced test set in CI on Mac and Windows
66
// machines.
77
@Tags(<String>['reduced-test-set'])
8-
@TestOn('!chrome')
98
library;
109

1110
import 'package:cupertino_ui/cupertino_ui.dart';

0 commit comments

Comments
 (0)