Skip to content

Commit 8cdc6e5

Browse files
authored
[google_maps_flutter_ios, pigeon, webview_flutter_wkwebview] Migrate remaining example apps to uiscene (flutter#13280)
Fixes flutter#194284 (+ a bonus extra special migration for `pigeon/example/native_interop_app`!! Wow!) These four example apps got missed out in the original round of migrations. - `webview_flutter_wkwebview/example` - In the initial example migration [sweep](flutter/packages#12182), `webview_flutter/webview_flutter/example` was migrated while `webview_flutter_wkwebview/example` was missed which is understandable - `google_maps_flutter_ios_sdk9/example` & `google_maps_flutter_ios_sdk10/example` - when I [migrated](flutter/packages#11001) `AppDelegate.swift` in `google_maps_flutter_ios_shared_code`, the sync script copied `AppDelegate.swift` into sdk9 and sdk10. But `Info.plist `isn't in shared_code, so the script didn't copy `Info.plist` - `pigeon/example/native_interop_app` - This was landed post the round of example migrations. Its `AppDelegate.swift` already adopts `FlutterImplicitEngineDelegate`, so it only needed `UIApplicationSceneManifest` in `Info.plist`. ## Pre-Review Checklist - [] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
1 parent 9919dfd commit 8cdc6e5

6 files changed

Lines changed: 89 additions & 2 deletions

File tree

‎packages/google_maps_flutter/google_maps_flutter_ios_sdk10/example/ios/Runner/Info.plist‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,26 @@
4949
<true/>
5050
<key>UIApplicationSupportsIndirectInputEvents</key>
5151
<true/>
52+
<key>UIApplicationSceneManifest</key>
53+
<dict>
54+
<key>UIApplicationSupportsMultipleScenes</key>
55+
<false/>
56+
<key>UISceneConfigurations</key>
57+
<dict>
58+
<key>UIWindowSceneSessionRoleApplication</key>
59+
<array>
60+
<dict>
61+
<key>UISceneClassName</key>
62+
<string>UIWindowScene</string>
63+
<key>UISceneDelegateClassName</key>
64+
<string>FlutterSceneDelegate</string>
65+
<key>UISceneConfigurationName</key>
66+
<string>flutter</string>
67+
<key>UISceneStoryboardFile</key>
68+
<string>Main</string>
69+
</dict>
70+
</array>
71+
</dict>
72+
</dict>
5273
</dict>
5374
</plist>

‎packages/google_maps_flutter/google_maps_flutter_ios_sdk9/example/ios/Runner/Info.plist‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,26 @@
4949
<true/>
5050
<key>UIApplicationSupportsIndirectInputEvents</key>
5151
<true/>
52+
<key>UIApplicationSceneManifest</key>
53+
<dict>
54+
<key>UIApplicationSupportsMultipleScenes</key>
55+
<false/>
56+
<key>UISceneConfigurations</key>
57+
<dict>
58+
<key>UIWindowSceneSessionRoleApplication</key>
59+
<array>
60+
<dict>
61+
<key>UISceneClassName</key>
62+
<string>UIWindowScene</string>
63+
<key>UISceneDelegateClassName</key>
64+
<string>FlutterSceneDelegate</string>
65+
<key>UISceneConfigurationName</key>
66+
<string>flutter</string>
67+
<key>UISceneStoryboardFile</key>
68+
<string>Main</string>
69+
</dict>
70+
</array>
71+
</dict>
72+
</dict>
5273
</dict>
5374
</plist>

‎packages/pigeon/example/native_interop_app/ios/Runner/Info.plist‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,26 @@
4545
<true/>
4646
<key>UIApplicationSupportsIndirectInputEvents</key>
4747
<true/>
48+
<key>UIApplicationSceneManifest</key>
49+
<dict>
50+
<key>UIApplicationSupportsMultipleScenes</key>
51+
<false/>
52+
<key>UISceneConfigurations</key>
53+
<dict>
54+
<key>UIWindowSceneSessionRoleApplication</key>
55+
<array>
56+
<dict>
57+
<key>UISceneClassName</key>
58+
<string>UIWindowScene</string>
59+
<key>UISceneDelegateClassName</key>
60+
<string>FlutterSceneDelegate</string>
61+
<key>UISceneConfigurationName</key>
62+
<string>flutter</string>
63+
<key>UISceneStoryboardFile</key>
64+
<string>Main</string>
65+
</dict>
66+
</array>
67+
</dict>
68+
</dict>
4869
</dict>
4970
</plist>

‎packages/webview_flutter/webview_flutter_wkwebview/example/ios/Runner/AppDelegate.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
#import <Flutter/Flutter.h>
66
#import <UIKit/UIKit.h>
77

8-
@interface AppDelegate : FlutterAppDelegate
8+
@interface AppDelegate : FlutterAppDelegate <FlutterImplicitEngineDelegate>
99

1010
@end

‎packages/webview_flutter/webview_flutter_wkwebview/example/ios/Runner/AppDelegate.m‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,12 @@ @implementation AppDelegate
99

1010
- (BOOL)application:(UIApplication *)application
1111
didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
12-
[GeneratedPluginRegistrant registerWithRegistry:self];
1312
// Override point for customization after application launch.
1413
return [super application:application didFinishLaunchingWithOptions:launchOptions];
1514
}
1615

16+
- (void)didInitializeImplicitFlutterEngine:(NSObject<FlutterImplicitEngineBridge> *)engineBridge {
17+
[GeneratedPluginRegistrant registerWithRegistry:engineBridge.pluginRegistry];
18+
}
19+
1720
@end

‎packages/webview_flutter/webview_flutter_wkwebview/example/ios/Runner/Info.plist‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,27 @@
2626
<string>LaunchScreen</string>
2727
<key>UIMainStoryboardFile</key>
2828
<string>Main</string>
29+
<key>UIApplicationSceneManifest</key>
30+
<dict>
31+
<key>UIApplicationSupportsMultipleScenes</key>
32+
<false/>
33+
<key>UISceneConfigurations</key>
34+
<dict>
35+
<key>UIWindowSceneSessionRoleApplication</key>
36+
<array>
37+
<dict>
38+
<key>UISceneClassName</key>
39+
<string>UIWindowScene</string>
40+
<key>UISceneDelegateClassName</key>
41+
<string>FlutterSceneDelegate</string>
42+
<key>UISceneConfigurationName</key>
43+
<string>flutter</string>
44+
<key>UISceneStoryboardFile</key>
45+
<string>Main</string>
46+
</dict>
47+
</array>
48+
</dict>
49+
</dict>
2950
<key>UISupportedInterfaceOrientations</key>
3051
<array>
3152
<string>UIInterfaceOrientationPortrait</string>

0 commit comments

Comments
 (0)