You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 8bd95a5
Browse filesBrowse the repository at this point in the historyBrowse files
[pigeon] Replace full JNI bindings with stubs for API classes that aren't needed (flutter#13173)
The generated JNIgen config bound both the Kotlin interface and the `Registrar` for each HostApi, but the generated Dart only calls the `Registrar`, so the interface bindings were dead code. HostApis now list only the `Registrar`. FlutterApi interfaces are still bound, since Dart implements them. The test plugin's `.jni.dart` drops from 40,978 to 25,520 lines (−37.7%), and the `Registrar` bindings are byte-identical.
Also removes the HostApi entry from the FFIgen config. The Swift protocol isn't `@objc`, so FFIgen never saw it, and the generated `.ffi.dart` is unchanged.
Fixesflutter#193882
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
0 commit comments