Repository navigation
Commit 8615faf
authored
[material_ui] Unskip web tests that pass on CanvasKit and Skwasm: time_picker_test (flutter#13471)
Removes the `@TestOn('!chrome')` annotation from `packages/material_ui/test/time_picker_test.dart` so that its tests run on the web. All 190 tests in the file now pass on Chrome under both CI web renderers (CanvasKit with dart2js and Skwasm with dart2wasm). The time picker state restoration group still does not work on the web, so it is now skipped individually with `skip: kIsWeb` instead of skipping the whole file.
Part of flutter#33615 (the state restoration group remains skipped on web pending that issue).
This is a test-only change, so it is exempt from version and CHANGELOG updates.
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.1 parent ccbe75f commit 8615faf
1 file changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
| |||
2354 | 2353 | | |
2355 | 2354 | | |
2356 | 2355 | | |
| 2356 | + | |
| 2357 | + | |
| 2358 | + | |
| 2359 | + | |
2357 | 2360 | | |
2358 | 2361 | | |
2359 | 2362 | | |
| |||
2461 | 2464 | | |
2462 | 2465 | | |
2463 | 2466 | | |
2464 | | - | |
| 2467 | + | |
2465 | 2468 | | |
2466 | 2469 | | |
2467 | 2470 | | |
| |||
0 commit comments