Skip to content

Commit 6c76d46

Browse files
[google_sign_in] PR 4/4 Convert the Pigeon host API from Objective-C to Swift (flutter#12658)
Converts the Pigeon host API from Objective-C to Swift (`swiftOut` / `messages.g.swift`) and implements `GoogleSignInApi` with throws/`Result` instead of Obj-C error pointers. Generated Swift is committed codegen from `pigeons/messages.dart` (Pigeon 26.3.4), then `swift-format`. `messages.g.h` / `messages.g.m` are removed. The Obj-C SPM target’s `publicHeadersPath` is narrowed to the remaining Obj-C headers. Missing-presenter failures from PR 3/4 are returned as `PigeonError`. Tests updated for the Swift Pigeon types. Bumps `google_sign_in_ios` to **6.3.5**. PR 4/4 of the Obj-C → Swift migration. Depends on PR 3/4 (ViewProvider / GID wrappers). Completes flutter#119103 for the iOS/macOS plugin implementation. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent bae3238 commit 6c76d46

14 files changed

Lines changed: 1525 additions & 1703 deletions

File tree

‎packages/google_sign_in/google_sign_in_ios/CHANGELOG.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
## NEXT
1+
## 6.3.6
22

3+
* Converts the Pigeon host API from Objective-C to Swift.
34
* Updates minimum supported SDK version to Flutter 3.41/Dart 3.11.
45

56
## 6.3.5

0 commit comments

Comments
 (0)