Repository navigation
Commit 5d03858
authored
[tool] Exempt
Follow-up to flutter/packages#12686.
flutter/packages#12686 added `packages/material_ui/test_apps/a11y_assessments` and marked [`test_apps/` as ignored in `.pubignore`](https://github.com/flutter/packages/blob/ac2db9cfeaf69c5064739e0d477ef8cb9c19cd35/packages/material_ui/test_apps/.pubignore#L1-L2), so [`ValidateCommand.runForPackage`](https://github.com/flutter/packages/blob/ac2db9cfeaf69c5064739e0d477ef8cb9c19cd35/script/tool/lib/src/validate_command.dart#L176-L178) skips `test_apps/*` subpackages via `isPubIgnored`.
However, when `validate --check-for-missing-changes` runs on the enclosing `material_ui` package, `checkPackageChangeState` only exempted `test_apps/a11y_assessments/test/...` via `pathComponents.contains('test')` and flagged `test_apps/a11y_assessments/lib/...` as requiring a version and `CHANGELOG.md` update:
```
The following packages had errors:
packages/material_ui:
Missing version change
```
Example CI failures:
- https://ci.chromium.org/b/8668024481194498497 (on flutter/packages#13159)
This PR adds `pathComponents.first == 'test_apps'` to `_isTestChange` in `package_state_utils.dart`.test_apps/ from version and changelog checks (flutter#13255)1 parent 3675456 commit 5d03858
4 files changed
Lines changed: 24 additions & 1 deletion
File tree
- script/tool
- lib/src/common
- test
- common
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
1 | 5 | | |
2 | 6 | | |
3 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
138 | | - | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
139 | 141 | | |
140 | 142 | | |
141 | 143 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
137 | 153 | | |
138 | 154 | | |
139 | 155 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
982 | 982 | | |
983 | 983 | | |
984 | 984 | | |
| 985 | + | |
985 | 986 | | |
986 | 987 | | |
987 | 988 | | |
| |||
0 commit comments