Skip to content

Commit 585b3d1

Browse files
authored
[cupertino_ui] Remove redundant null arguments in Completer.complete (flutter#13008)
This is work towards dart-lang/sdk#59150 (https://dart-review.googlesource.com/c/sdk/+/491341). The `avoid_redundant_argument_values` lint rule is being updated to flag redundant `null` argument values passed to optional nullable parameters with no default value (such as `Completer.complete([FutureOr<T>? value])`). ## Pre-Review Checklist
1 parent 2bc9395 commit 585b3d1

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

‎packages/cupertino_ui/test/refresh_test.dart‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ void main() {
334334
await tester.pump(const Duration(seconds: 1000));
335335
expect(tester.getTopLeft(find.widgetWithText(SizedBox, '0')), const Offset(0.0, 60.0));
336336

337-
mockHelper.refreshCompleter.complete(null);
337+
mockHelper.refreshCompleter.complete();
338338
await tester.pump();
339339

340340
expect(
@@ -623,7 +623,7 @@ void main() {
623623
const Rect.fromLTRB(0.0, 60.0, 800.0, 260.0),
624624
);
625625

626-
mockHelper.refreshCompleter.complete(null);
626+
mockHelper.refreshCompleter.complete();
627627
await tester.pump();
628628
expect(
629629
mockHelper.invocations,
@@ -712,7 +712,7 @@ void main() {
712712
const Rect.fromLTRB(0.0, 60.0, 800.0, 260.0),
713713
);
714714

715-
mockHelper.refreshCompleter.complete(null);
715+
mockHelper.refreshCompleter.complete();
716716
await tester.pump();
717717

718718
expect(
@@ -775,7 +775,7 @@ void main() {
775775
await tester.pump();
776776
expect(mockHelper.invocations, contains(const RefreshTaskInvocation()));
777777

778-
mockHelper.refreshCompleter.complete(null);
778+
mockHelper.refreshCompleter.complete();
779779
await tester.pump();
780780
expect(
781781
mockHelper.invocations,
@@ -888,7 +888,7 @@ void main() {
888888
expect(mockHelper.invocations, contains(const RefreshTaskInvocation()));
889889

890890
// Complete the task while held down.
891-
mockHelper.refreshCompleter.complete(null);
891+
mockHelper.refreshCompleter.complete();
892892
await tester.pump();
893893

894894
expect(
@@ -978,7 +978,7 @@ void main() {
978978
);
979979

980980
// Complete the task while scrolled away.
981-
mockHelper.refreshCompleter.complete(null);
981+
mockHelper.refreshCompleter.complete();
982982
// The sliver is instantly gone since there is no overscroll physics
983983
// simulation.
984984
await tester.pump();
@@ -1384,7 +1384,7 @@ void main() {
13841384
const Rect.fromLTRB(0.0, 60.0, 800.0, 260.0),
13851385
);
13861386

1387-
mockHelper.refreshCompleter.complete(null);
1387+
mockHelper.refreshCompleter.complete();
13881388
// The task completed between frames. The internal state goes to done
13891389
// right away even though the sliver gets a new offset correction the
13901390
// next frame.
@@ -1424,7 +1424,7 @@ void main() {
14241424
RefreshIndicatorMode.armed,
14251425
);
14261426

1427-
mockHelper.refreshCompleter.complete(null);
1427+
mockHelper.refreshCompleter.complete();
14281428
expect(
14291429
CupertinoSliverRefreshControl.state(tester.element(find.byType(LayoutBuilder))),
14301430
RefreshIndicatorMode.done,
@@ -1521,7 +1521,7 @@ void main() {
15211521
RefreshIndicatorMode.refresh,
15221522
);
15231523

1524-
mockHelper.refreshCompleter.complete(null);
1524+
mockHelper.refreshCompleter.complete();
15251525
// The sliver layout extent is removed on next frame.
15261526
await tester.pump();
15271527
expect(
@@ -1589,7 +1589,7 @@ void main() {
15891589
const Rect.fromLTRB(0.0, 0.0, 800.0, 200.0),
15901590
);
15911591

1592-
mockHelper.refreshCompleter.complete(null);
1592+
mockHelper.refreshCompleter.complete();
15931593
await tester.pump();
15941594
// Goes to inactive right away since the sliver is already collapsed.
15951595
expect(

0 commit comments

Comments
 (0)