Repository navigation
Commit 456fa7f
authored
[google_sign_in] PR 2/4 Migrate the plugin class from Objective-C to Swift. (flutter#12655)
Migrates `FLTGoogleSignInPlugin` from Objective-C to Swift (`GoogleSignInPlugin.swift`). GID SDK wrappers and `ViewProvider` stay Obj-C for this PR.
Intended as a 1:1 move of configure, restorePreviousSignIn, signIn, refreshedAuthorizationTokens, addScopes, signOut, disconnect, error-code mapping, URL handling, and the iOS view-controller / macOS window presentation paths.
`presentingViewController` / `presentingWindow` on the Obj-C wrapper protocol become nullable. That matches existing runtime behavior: `FSIViewProvider.viewController` was already nullable.
Bumps `google_sign_in_ios` to **6.3.3**.
PR 2/4 of the Obj-C → Swift migration. Depends on PR 1/4 (SPM packaging). Continues flutter#119103
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.1 parent 330115e commit 456fa7f
14 files changed
Lines changed: 597 additions & 540 deletions
File tree
- packages/google_sign_in/google_sign_in_ios
- darwin
- Tests
- google_sign_in_ios
- Sources
- google_sign_in_ios_objc
- include
- google_sign_in_ios_objc
- google_sign_in_ios
- google_sign_in_ios
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
1 | 8 | | |
2 | 9 | | |
3 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
216 | | - | |
| 216 | + | |
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
| |||
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
229 | | - | |
| 229 | + | |
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| |||
373 | 373 | | |
374 | 374 | | |
375 | 375 | | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
376 | 405 | | |
377 | 406 | | |
378 | 407 | | |
| |||
728 | 757 | | |
729 | 758 | | |
730 | 759 | | |
| 760 | + | |
731 | 761 | | |
732 | | - | |
733 | | - | |
734 | | - | |
735 | | - | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
736 | 766 | | |
737 | | - | |
| 767 | + | |
738 | 768 | | |
739 | | - | |
740 | | - | |
741 | | - | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
742 | 783 | | |
743 | 784 | | |
744 | 785 | | |
| |||
936 | 977 | | |
937 | 978 | | |
938 | 979 | | |
939 | | - | |
| 980 | + | |
940 | 981 | | |
941 | 982 | | |
942 | | - | |
| 983 | + | |
943 | 984 | | |
944 | 985 | | |
945 | 986 | | |
946 | 987 | | |
947 | 988 | | |
948 | | - | |
| 989 | + | |
949 | 990 | | |
950 | 991 | | |
951 | 992 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| |||
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
40 | | - | |
| 41 | + | |
| 42 | + | |
41 | 43 | | |
42 | 44 | | |
43 | 45 | | |
| |||
0 commit comments