Skip to content

Commit 3565517

Browse files
author
Jonah Williams
authored
[impeller] use greater equal rather than greater depth compare. (flutter#56310)
Marking ready for review for golden testing Fixes flutter#153504 Fixes some other ones too? It seems like metal and vulkan are already behaving like they are using greater equal depth compare. GL behaves correctly like greater compare, but that leads to rendering bugs. Just switch it to greater equal
1 parent 7dfdcac commit 3565517

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎impeller/entity/contents/contents.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ ContentContextOptions OptionsFromPass(const RenderPass& pass) {
2626
FML_DCHECK(pass.HasDepthAttachment() == pass.HasStencilAttachment());
2727

2828
opts.has_depth_stencil_attachments = has_depth_stencil_attachments;
29-
opts.depth_compare = CompareFunction::kGreater;
29+
opts.depth_compare = CompareFunction::kGreaterEqual;
3030
opts.stencil_mode = ContentContextOptions::StencilMode::kIgnore;
3131
return opts;
3232
}

0 commit comments

Comments
 (0)