Skip to content

Commit 1785501

Browse files
authored
[material_ui] Cleans up shader files and exposes ink_splash shader (flutter#12421)
the ink_splash is still using the flutter sdk's shader file, this pr fixes it ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 111fea5 commit 1785501

5 files changed

Lines changed: 10 additions & 160 deletions

File tree

File renamed without changes.

‎packages/material_ui/lib/src/ink_sparkle.dart‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,9 @@ class _InkSparkleFactory extends InteractiveInkFeatureFactory {
424424

425425
static void initializeShader() {
426426
if (!_initCalled) {
427-
ui.FragmentProgram.fromAsset('shaders/ink_sparkle.frag').then((ui.FragmentProgram program) {
427+
ui.FragmentProgram.fromAsset('packages/material_ui/shaders/ink_sparkle.frag').then((
428+
ui.FragmentProgram program,
429+
) {
428430
_program = program;
429431
});
430432
_initCalled = true;

‎packages/material_ui/lib/src/shaders/stretch_effect.frag‎

Lines changed: 0 additions & 159 deletions
This file was deleted.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
changelog: |
2+
- Exposes ink_sparkle shader asset in pubspec.yaml and removes stretch_effect shader.
3+
version: minor

‎packages/material_ui/pubspec.yaml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ dev_dependencies:
3232
path: ^1.9.1
3333
platform: ^3.1.6
3434

35+
flutter:
36+
shaders:
37+
- packages/material_ui/shaders/ink_sparkle.frag
38+
3539
topics:
3640
- ui
3741
- widgets

0 commit comments

Comments
 (0)