Repository navigation
Commit 13b5214
authored
[material_ui] Improve Autocomplete, DrawerHeader, and Tooltip accessibility (flutter#12918)
Adds three targeted accessibility improvements to `packages/material_ui`:
1. **`Autocomplete` option selection state (`lib/src/autocomplete.dart`)**:
- Passes `selected: highlight` to the `Semantics` wrapper around each option in `_AutocompleteOptions` so screen readers announce which autocomplete option is currently highlighted/selected (`aria-selected` / `aria-current`).
2. **`DrawerHeader` header semantics (`lib/src/drawer_header.dart`)**:
- Wraps `DrawerHeader` in `Semantics(header: true)` so drawer titles expose semantic heading/header structure (`<h2>` via `effectiveHeadingLevel = 2` on Web when `hasLabel && !hasChildren`, and `<header>` when wrapping composite children like `UserAccountsDrawerHeader`).
3. **`TooltipThemeData.ignorePointer` (`lib/src/tooltip_theme.dart`, `lib/src/tooltip.dart`)**:
- Adds `ignorePointer` to `TooltipThemeData` and wires `Tooltip` to consult `_tooltipTheme.ignorePointer` before falling back to `widget.message != null`, allowing apps to configure hoverable plain-text tooltips globally via `ThemeData(tooltipTheme: const TooltipThemeData(ignorePointer: false))` (satisfying WCAG 1.4.13 Hoverable without breaking `flutter#182527` default pass-through hit-testing).
Related Flutter Web VPAT issues:
- Autocomplete options (`#/auto-complete`, WCAG 4.1.2): [http://b/464138739](http://b/464138739), [http://b/460080184](http://b/460080184)
- Drawer & NavigationDrawer (`#/drawer`, `#/navigation-drawer`, WCAG 1.3.1): [http://b/462581277](http://b/462581277), [http://b/462597561](http://b/462597561)
- Tooltip Hoverable (`WCAG 1.4.13`): [http://b/463913706](http://b/463913706), [http://b/463912499](http://b/463912499), [http://b/463910116](http://b/463910116), [http://b/463900105](http://b/463900105), [http://b/462283112](http://b/462283112), [http://b/462276641](http://b/462276641)
## Pre-Adoption Checklist1 parent 72a0a40 commit 13b5214
9 files changed
Lines changed: 133 additions & 19 deletions
File tree
- packages/material_ui
- lib/src
- pending_changelogs
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
318 | 318 | | |
319 | 319 | | |
320 | 320 | | |
| 321 | + | |
321 | 322 | | |
322 | 323 | | |
| 324 | + | |
323 | 325 | | |
324 | 326 | | |
325 | 327 | | |
326 | 328 | | |
327 | 329 | | |
328 | 330 | | |
329 | 331 | | |
330 | | - | |
331 | 332 | | |
332 | 333 | | |
333 | 334 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
100 | 103 | | |
101 | 104 | | |
102 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
575 | 575 | | |
576 | 576 | | |
577 | 577 | | |
578 | | - | |
| 578 | + | |
| 579 | + | |
579 | 580 | | |
580 | 581 | | |
581 | 582 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
| |||
137 | 138 | | |
138 | 139 | | |
139 | 140 | | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
140 | 149 | | |
141 | 150 | | |
142 | 151 | | |
| |||
159 | 168 | | |
160 | 169 | | |
161 | 170 | | |
| 171 | + | |
162 | 172 | | |
163 | 173 | | |
164 | 174 | | |
| |||
173 | 183 | | |
174 | 184 | | |
175 | 185 | | |
| 186 | + | |
176 | 187 | | |
177 | 188 | | |
| 189 | + | |
178 | 190 | | |
179 | 191 | | |
180 | 192 | | |
| |||
198 | 210 | | |
199 | 211 | | |
200 | 212 | | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
201 | 219 | | |
202 | 220 | | |
203 | 221 | | |
| |||
218 | 236 | | |
219 | 237 | | |
220 | 238 | | |
| 239 | + | |
221 | 240 | | |
222 | 241 | | |
223 | 242 | | |
| |||
243 | 262 | | |
244 | 263 | | |
245 | 264 | | |
246 | | - | |
| 265 | + | |
| 266 | + | |
247 | 267 | | |
248 | 268 | | |
249 | 269 | | |
| |||
286 | 306 | | |
287 | 307 | | |
288 | 308 | | |
| 309 | + | |
289 | 310 | | |
290 | 311 | | |
291 | 312 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
893 | 893 | | |
894 | 894 | | |
895 | 895 | | |
896 | | - | |
| 896 | + | |
897 | 897 | | |
898 | 898 | | |
899 | 899 | | |
900 | 900 | | |
901 | 901 | | |
902 | 902 | | |
| 903 | + | |
| 904 | + | |
903 | 905 | | |
904 | 906 | | |
905 | 907 | | |
906 | 908 | | |
907 | 909 | | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
908 | 921 | | |
909 | 922 | | |
910 | 923 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1516 | 1516 | | |
1517 | 1517 | | |
1518 | 1518 | | |
| 1519 | + | |
| 1520 | + | |
| 1521 | + | |
| 1522 | + | |
| 1523 | + | |
| 1524 | + | |
| 1525 | + | |
| 1526 | + | |
| 1527 | + | |
| 1528 | + | |
| 1529 | + | |
| 1530 | + | |
| 1531 | + | |
| 1532 | + | |
| 1533 | + | |
1519 | 1534 | | |
1520 | 1535 | | |
1521 | 1536 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
26 | 58 | | |
27 | 59 | | |
28 | 60 | | |
| |||
41 | 73 | | |
42 | 74 | | |
43 | 75 | | |
| 76 | + | |
44 | 77 | | |
45 | 78 | | |
46 | 79 | | |
| |||
62 | 95 | | |
63 | 96 | | |
64 | 97 | | |
| 98 | + | |
65 | 99 | | |
66 | 100 | | |
67 | 101 | | |
| |||
76 | 110 | | |
77 | 111 | | |
78 | 112 | | |
| 113 | + | |
79 | 114 | | |
80 | 115 | | |
81 | 116 | | |
| |||
97 | 132 | | |
98 | 133 | | |
99 | 134 | | |
| 135 | + | |
100 | 136 | | |
101 | 137 | | |
102 | 138 | | |
| |||
1540 | 1576 | | |
1541 | 1577 | | |
1542 | 1578 | | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
| 1588 | + | |
| 1589 | + | |
| 1590 | + | |
| 1591 | + | |
| 1592 | + | |
| 1593 | + | |
| 1594 | + | |
| 1595 | + | |
1543 | 1596 | | |
1544 | 1597 | | |
1545 | 1598 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
494 | 494 | | |
495 | 495 | | |
496 | 496 | | |
| 497 | + | |
497 | 498 | | |
498 | 499 | | |
499 | 500 | | |
| |||
559 | 560 | | |
560 | 561 | | |
561 | 562 | | |
| 563 | + | |
562 | 564 | | |
563 | 565 | | |
564 | 566 | | |
| |||
0 commit comments