Repository navigation
Commit 01d0873
authored
[google_sign_in] Convert unit tests to Kotlin (flutter#13000)
Converts `google_sign_in_android` native unit tests from Java to Kotlin.
Similar to my other conversions, the process was:
- Use the Android Studio deterministic auto-conversion.
- Do a bunch of manual cleanup, as separate commits by topic.
- This included adopting `mockito-kotlin` to make the mocking much less verbose and complex
- Do a local Gemini review for where the code could be improved as Kotlin code, and address most of that feedback.
This also removes the test-only bridge code that allowed using `Result` in Java tests, now that it is no longer necessary.
Does not include any changes to production code.
Part of flutter#188630
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.1 parent c63648d commit 01d0873
4 files changed
Lines changed: 1029 additions & 1293 deletions
File tree
- packages/google_sign_in/google_sign_in_android/android
- src/test
- java/io/flutter/plugins/googlesignin
- kotlin/io/flutter/plugins/googlesignin
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| 77 | + | |
77 | 78 | | |
0 commit comments