Skip to content

Commit 01d0873

Browse files
[google_sign_in] Convert unit tests to Kotlin (flutter#13000)
Converts `google_sign_in_android` native unit tests from Java to Kotlin. Similar to my other conversions, the process was: - Use the Android Studio deterministic auto-conversion. - Do a bunch of manual cleanup, as separate commits by topic. - This included adopting `mockito-kotlin` to make the mocking much less verbose and complex - Do a local Gemini review for where the code could be improved as Kotlin code, and address most of that feedback. This also removes the test-only bridge code that allowed using `Result` in Java tests, now that it is no longer necessary. Does not include any changes to production code. Part of flutter#188630 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent c63648d commit 01d0873

4 files changed

Lines changed: 1029 additions & 1293 deletions

File tree

‎packages/google_sign_in/google_sign_in_android/android/build.gradle.kts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,4 +74,5 @@ dependencies {
7474
implementation("com.google.android.gms:play-services-auth:21.6.0")
7575
testImplementation("junit:junit:4.13.2")
7676
testImplementation("org.mockito:mockito-core:5.23.0")
77+
testImplementation("org.mockito.kotlin:mockito-kotlin:6.3.0")
7778
}

0 commit comments

Comments
 (0)