Questions, FAQ and settings fixes#782
Merged
msquare merged 4 commits intoengelsystem:masterfrom Dec 20, 2020
Merged
Conversation
Member
MyIgel
commented
Dec 18, 2020
MyIgel
commented
- Rebuild the Questions frontend
- Added a FAQ feature
- Use maxlength on user settings to prevent 500 errors
MyIgel
added
Type: Feature
msquare
requested changes
Dec 20, 2020
Member
msquare
left a comment
msquare
left a comment
There was a problem hiding this comment.
Nice work, as always!
Since the faq is now included in the footer per default config and therefore also visible for visitors, the migration script should add the view faq permission to the guest role as well.
And all "icon only" buttons should get a title, but not in this pr i guess.
MyIgel
force-pushed
the
questions-faq-and-settings
branch
from
e5cf4da to
7f2c42b
Compare
msquare
approved these changes
Dec 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.