Repository navigation
Commit 4b8bc50
opencode
fix: revert the key-shape change; Go keys are oc_sk_, not sk-
Reverts the key half of 5d9640e. That commit concluded from
anomalyco/opencode#40343 and #44948 that Go keys are `sk-` plus 64 characters
and widened `_is_opencode_go_key` to accept `sk-`, flattening the precedence
rules to "the environment always wins". Both conclusions were wrong: those
issues describe **Zen** keys, which is a different product, and a Go key starts
with `oc_sk_`.
The widened predicate was actively harmful, not merely unnecessary. `sk-` is the
format shared by OpenAI, Anthropic, DashScope and Zen, so accepting it hands
every foreign profile key straight to the gateway -- reintroducing exactly the
`Invalid API key.` failure the guard was added to prevent, and discarding the
shape test's only reason to exist. The corrected code keeps `oc_` only, restores
the original precedence (a Go-shaped profile key is kept, a foreign one is
replaced by the environment variable or refused), and the docstring now says
plainly not to widen it on the strength of a Zen source.
The three tests I rewrote asserted the wrong premise and are restored to their
original forms, with docstrings noting what went wrong so the next person does
not re-derive it from the same issue numbers. test_go_shaped_profile_key_is_kept
is back: under the original precedence it is the inverse case the other two do
not cover, not a duplicate.
The rest of 5d9640e stands, because it did not depend on the key claim: the
Go catalog is now explicit sets transcribed from the published endpoint table
rather than a range comprehension that invented models, `deepseek-v4-flash-
vision-exp` is answered for as vision-capable instead of having its images
silently replaced by text, and the catalog and vision behaviour are documented.
Qwen3.5 Plus is left out of the messages list because it is not in the current
Go endpoint table; the table is the authority here, and
GET /zen/go/v1/models is the live version of it.
Suite unchanged at the known baseline of 14.1 parent 5d9640e commit 4b8bc50
3 files changed
Lines changed: 84 additions & 91 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
234 | 235 | | |
235 | 236 | | |
236 | 237 | | |
| |||
245 | 246 | | |
246 | 247 | | |
247 | 248 | | |
248 | | - | |
| 249 | + | |
249 | 250 | | |
250 | 251 | | |
251 | 252 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
156 | 151 | | |
157 | | - | |
| 152 | + | |
158 | 153 | | |
159 | 154 | | |
160 | 155 | | |
| |||
850 | 845 | | |
851 | 846 | | |
852 | 847 | | |
853 | | - | |
854 | | - | |
855 | | - | |
856 | | - | |
857 | | - | |
858 | | - | |
859 | | - | |
860 | | - | |
861 | | - | |
862 | | - | |
863 | | - | |
864 | | - | |
865 | | - | |
866 | | - | |
867 | | - | |
868 | | - | |
869 | | - | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
870 | 864 | | |
871 | 865 | | |
872 | 866 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
199 | 193 | | |
200 | | - | |
| 194 | + | |
201 | 195 | | |
202 | | - | |
203 | | - | |
| 196 | + | |
204 | 197 | | |
| 198 | + | |
| 199 | + | |
205 | 200 | | |
206 | | - | |
| 201 | + | |
| 202 | + | |
207 | 203 | | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
208 | 213 | | |
209 | | - | |
210 | | - | |
211 | 214 | | |
212 | | - | |
213 | | - | |
214 | | - | |
| 215 | + | |
| 216 | + | |
215 | 217 | | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
222 | 221 | | |
223 | 222 | | |
224 | 223 | | |
225 | | - | |
| 224 | + | |
226 | 225 | | |
227 | 226 | | |
228 | 227 | | |
229 | | - | |
| 228 | + | |
230 | 229 | | |
231 | 230 | | |
232 | 231 | | |
| |||
263 | 262 | | |
264 | 263 | | |
265 | 264 | | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
275 | 274 | | |
276 | 275 | | |
277 | 276 | | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
282 | 281 | | |
283 | 282 | | |
284 | 283 | | |
| |||
291 | 290 | | |
292 | 291 | | |
293 | 292 | | |
294 | | - | |
| 293 | + | |
295 | 294 | | |
296 | 295 | | |
297 | 296 | | |
| |||
301 | 300 | | |
302 | 301 | | |
303 | 302 | | |
304 | | - | |
| 303 | + | |
305 | 304 | | |
306 | | - | |
307 | | - | |
308 | | - | |
| 305 | + | |
| 306 | + | |
309 | 307 | | |
310 | 308 | | |
311 | 309 | | |
| |||
0 commit comments