Skip to content

Commit a588239

Browse files
committed
ci: pin Node 24.x matrix to 24.18.0 (worker-teardown crash)
Node 24.19.0 regressed process teardown with a use-after-free in CleanupHookThunkRun, which crashes better-sqlite3 11.10.0 AVA workers in RemoveEnvironmentCleanupHook (Assertion failed: (env) != nullptr). The floating 24.x matrix advanced 24.18.0 -> 24.19.0 mid-cycle and turned 'test (24.x, ubuntu-latest)' red across unrelated PRs. Pin the four 24.x matrix entries to 24.18.0 (last known-good) so the float stops. Lift once the Node fix ships. Refs: nodejs/node#65195 Refs: nodejs/node#65196
1 parent eb6da16 commit a588239

1 file changed

Lines changed: 28 additions & 4 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,13 @@ jobs:
163163
strategy:
164164
fail-fast: false
165165
matrix:
166-
node-version: [22.x, 24.x]
166+
# Node 24.x is pinned to 24.18.0: 24.19.0 regressed teardown with a
167+
# use-after-free in CleanupHookThunkRun, crashing better-sqlite3 AVA
168+
# workers in RemoveEnvironmentCleanupHook (Assertion failed:
169+
# (env) != nullptr). Lift the pin once the Node fix ships.
170+
# https://github.com/nodejs/node/issues/65195
171+
# https://github.com/nodejs/node/pull/65196
172+
node-version: [22.x, 24.18.0]
167173
platform: [ubuntu-latest, macos-15]
168174
# windows-latest exhibited flakey tests that are not yet worth the
169175
# trouble to investigate, and blocked us from upgrading yarn from 1 to
@@ -329,7 +335,13 @@ jobs:
329335
strategy:
330336
fail-fast: false
331337
matrix:
332-
node-version: [22.x, 24.x]
338+
# Node 24.x is pinned to 24.18.0: 24.19.0 regressed teardown with a
339+
# use-after-free in CleanupHookThunkRun, crashing better-sqlite3 AVA
340+
# workers in RemoveEnvironmentCleanupHook (Assertion failed:
341+
# (env) != nullptr). Lift the pin once the Node fix ships.
342+
# https://github.com/nodejs/node/issues/65195
343+
# https://github.com/nodejs/node/pull/65196
344+
node-version: [22.x, 24.18.0]
333345
platform: [ubuntu-latest]
334346

335347
steps:
@@ -371,7 +383,13 @@ jobs:
371383
strategy:
372384
fail-fast: false
373385
matrix:
374-
node-version: [22.x, 24.x]
386+
# Node 24.x is pinned to 24.18.0: 24.19.0 regressed teardown with a
387+
# use-after-free in CleanupHookThunkRun, crashing better-sqlite3 AVA
388+
# workers in RemoveEnvironmentCleanupHook (Assertion failed:
389+
# (env) != nullptr). Lift the pin once the Node fix ships.
390+
# https://github.com/nodejs/node/issues/65195
391+
# https://github.com/nodejs/node/pull/65196
392+
node-version: [22.x, 24.18.0]
375393
platform: [ubuntu-latest]
376394

377395
steps:
@@ -477,7 +495,13 @@ jobs:
477495
strategy:
478496
fail-fast: false
479497
matrix:
480-
node-version: [22.x, 24.x]
498+
# Node 24.x is pinned to 24.18.0: 24.19.0 regressed teardown with a
499+
# use-after-free in CleanupHookThunkRun, crashing better-sqlite3 AVA
500+
# workers in RemoveEnvironmentCleanupHook (Assertion failed:
501+
# (env) != nullptr). Lift the pin once the Node fix ships.
502+
# https://github.com/nodejs/node/issues/65195
503+
# https://github.com/nodejs/node/pull/65196
504+
node-version: [22.x, 24.18.0]
481505
platform: [ubuntu-latest]
482506

483507
steps:

0 commit comments

Comments
 (0)