Skip to content

Commit 692f480

Browse files
committed
ci: pin Node 24.x matrix to 24.18.0 (worker-teardown crash)
Node 24.19.0 regressed process teardown with a use-after-free in CleanupHookThunkRun, which crashes better-sqlite3 11.10.0 AVA workers in RemoveEnvironmentCleanupHook (Assertion failed: (env) != nullptr). The floating 24.x matrix advanced 24.18.0 -> 24.19.0 mid-cycle and turned 'test (24.x, ubuntu-latest)' red across unrelated PRs. Pin the four 24.x matrix entries to 24.18.0 (last known-good) so the float stops. Lift once the Node fix ships. Refs: nodejs/node#65195 Refs: nodejs/node#65196
1 parent a59021f commit 692f480

1 file changed

Lines changed: 24 additions & 12 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,12 @@ jobs:
163163
strategy:
164164
fail-fast: false
165165
matrix:
166-
# Temporarily pin Node 24: Node 24.19 triggers the [email protected]
167-
# legacy node::ObjectWrap cleanup abort; see
168-
# https://github.com/nodejs/node/pull/65042.
166+
# Node 24.x is pinned to 24.18.0: 24.19.0 regressed teardown with a
167+
# use-after-free in CleanupHookThunkRun, crashing better-sqlite3 AVA
168+
# workers in RemoveEnvironmentCleanupHook (Assertion failed:
169+
# (env) != nullptr). Lift the pin once the Node fix ships.
170+
# https://github.com/nodejs/node/issues/65195
171+
# https://github.com/nodejs/node/pull/65196
169172
node-version: [22.x, 24.18.0]
170173
platform: [ubuntu-latest, macos-15]
171174
# windows-latest exhibited flakey tests that are not yet worth the
@@ -332,9 +335,12 @@ jobs:
332335
strategy:
333336
fail-fast: false
334337
matrix:
335-
# Temporarily pin Node 24: Node 24.19 triggers the [email protected]
336-
# legacy node::ObjectWrap cleanup abort; see
337-
# https://github.com/nodejs/node/pull/65042.
338+
# Node 24.x is pinned to 24.18.0: 24.19.0 regressed teardown with a
339+
# use-after-free in CleanupHookThunkRun, crashing better-sqlite3 AVA
340+
# workers in RemoveEnvironmentCleanupHook (Assertion failed:
341+
# (env) != nullptr). Lift the pin once the Node fix ships.
342+
# https://github.com/nodejs/node/issues/65195
343+
# https://github.com/nodejs/node/pull/65196
338344
node-version: [22.x, 24.18.0]
339345
platform: [ubuntu-latest]
340346

@@ -377,9 +383,12 @@ jobs:
377383
strategy:
378384
fail-fast: false
379385
matrix:
380-
# Temporarily pin Node 24: Node 24.19 triggers the [email protected]
381-
# legacy node::ObjectWrap cleanup abort; see
382-
# https://github.com/nodejs/node/pull/65042.
386+
# Node 24.x is pinned to 24.18.0: 24.19.0 regressed teardown with a
387+
# use-after-free in CleanupHookThunkRun, crashing better-sqlite3 AVA
388+
# workers in RemoveEnvironmentCleanupHook (Assertion failed:
389+
# (env) != nullptr). Lift the pin once the Node fix ships.
390+
# https://github.com/nodejs/node/issues/65195
391+
# https://github.com/nodejs/node/pull/65196
383392
node-version: [22.x, 24.18.0]
384393
platform: [ubuntu-latest]
385394

@@ -486,9 +495,12 @@ jobs:
486495
strategy:
487496
fail-fast: false
488497
matrix:
489-
# Temporarily pin Node 24: Node 24.19 triggers the [email protected]
490-
# legacy node::ObjectWrap cleanup abort; see
491-
# https://github.com/nodejs/node/pull/65042.
498+
# Node 24.x is pinned to 24.18.0: 24.19.0 regressed teardown with a
499+
# use-after-free in CleanupHookThunkRun, crashing better-sqlite3 AVA
500+
# workers in RemoveEnvironmentCleanupHook (Assertion failed:
501+
# (env) != nullptr). Lift the pin once the Node fix ships.
502+
# https://github.com/nodejs/node/issues/65195
503+
# https://github.com/nodejs/node/pull/65196
492504
node-version: [22.x, 24.18.0]
493505
platform: [ubuntu-latest]
494506

0 commit comments

Comments
 (0)