doc(marshal): adds missing comment from #2799 review#2801
Merged
Conversation
erights
force-pushed
the
markm-missing-comment-from-299-review
branch
from
May 15, 2025 21:09
ef73c72 to
25a283f
Compare
2 tasks
Contributor
|
Curious about your thoughts on #2799 (comment) as well if you're following up. |
Contributor
Author
|
dckc
approved these changes
May 15, 2025
boneskull
pushed a commit
that referenced
this pull request
Jun 4, 2025
Closes: #XXXX Refs: #2799 (comment) ## Description At #2799 (comment) @dckc suggested > I suggest including it in the comment. I intended to. But somehow I resolved it before actually doing this, causing me to miss it when evaluating if I should just merge-and-squash #2799. This PR corrects that omission. Minor internal comment only. It should not have any other implications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXXX
Refs: #2799 (comment)
Description
At #2799 (comment) @dckc suggested
I intended to. But somehow I resolved it before actually doing this, causing me to miss it when evaluating if I should just merge-and-squash #2799. This PR corrects that omission.
Minor internal comment only. It should not have any other implications.