feat(pass-style): Safe promises can override @@toStringTag with a string#1785
Merged
Conversation
erights
force-pushed
the
markm-label-promise-instances
branch
2 times, most recently
from
September 21, 2023 02:37
0782780 to
b4ddd1c
Compare
erights
force-pushed
the
markm-label-promise-instances
branch
from
September 26, 2023 02:18
b4ddd1c to
55e094c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1781 demonstrates that the current endo (and it just so happens, the already-released endo) enables a passable promise to carry the string that @FUDCo needs to support testing. However, its way of carrying a string was terribly obtuse.
This PR implements part of the plan explained at #1781 (comment) . Specifically, to have passable promises follow the precedent of passable far objects and exos, which also allow them to override the inherited @@toStringTag property with an own data property carrying a string value. However, agoric-sdk would not be able to use this more pleasant way of carrying a string until it is upgraded to depend on an endo containing this PR.