fix(patterns,exo): abstract guard getters#1745
Merged
Merged
Conversation
erights
force-pushed
the
markm-abstract-guard-tag
branch
from
August 28, 2023 02:54
58b00d6 to
019a872
Compare
erights
force-pushed
the
markm-abstract-guard-tag
branch
3 times, most recently
from
August 28, 2023 04:17
dd2e023 to
0e642c3
Compare
erights
force-pushed
the
markm-abstract-guard-tag
branch
2 times, most recently
from
August 29, 2023 05:00
14b381a to
4eb0bd1
Compare
Contributor
Author
|
Ready for review |
turadg
removed their request for review
August 29, 2023 18:13
Member
|
Removed myself as I won't have time until Friday. |
erights
force-pushed
the
markm-abstract-guard-tag
branch
2 times, most recently
from
August 30, 2023 01:18
4e66d97 to
ca66ee9
Compare
gibson042
approved these changes
Aug 30, 2023
erights
force-pushed
the
markm-abstract-guard-tag
branch
from
August 31, 2023 00:15
ca66ee9 to
dcf1071
Compare
erights
enabled auto-merge
August 31, 2023 00:17
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prepare for #1712 , first abstract access to the contents of the guards. Once agoric-sdk is updated to a version of endo with this PR, its use of guards can be switched from directly accessing record properties, which would break on transition to #1712 , to calling the getters defined here, which will work before and after.
Once all such access is changed, we can then do a later endo release incorporating #1712 without breaking agoric-sdk.