fix(patterns)!: tag and retype guards#1712
Merged
Merged
Conversation
erights
force-pushed
the
markm-tag-guards-2
branch
from
August 8, 2023 01:59
6a02ab0 to
6878f17
Compare
This was referenced Aug 8, 2023
erights
force-pushed
the
markm-tag-guards-2
branch
from
August 9, 2023 02:20
6878f17 to
1e25987
Compare
erights
force-pushed
the
markm-tag-guards-2
branch
2 times, most recently
from
August 9, 2023 02:27
b05871a to
2a13b3d
Compare
erights
changed the title
erights
force-pushed
the
markm-type-guards
branch
from
August 15, 2023 22:53
a0170df to
505f81f
Compare
erights
force-pushed
the
markm-tag-guards-2
branch
from
August 15, 2023 23:01
2a13b3d to
1cbe96d
Compare
erights
force-pushed
the
markm-type-guards
branch
from
August 21, 2023 22:48
505f81f to
c2cd034
Compare
erights
force-pushed
the
markm-tag-guards-2
branch
from
August 21, 2023 23:26
1cbe96d to
81cae91
Compare
erights
force-pushed
the
markm-tag-guards-2
branch
from
August 28, 2023 04:18
81cae91 to
3f9eda8
Compare
Contributor
Author
|
Reviewers, |
erights
force-pushed
the
markm-abstract-guard-tag
branch
from
August 28, 2023 05:09
0e642c3 to
14b381a
Compare
erights
force-pushed
the
markm-tag-guards-2
branch
from
August 28, 2023 05:10
3f9eda8 to
b13aa5b
Compare
erights
force-pushed
the
markm-abstract-guard-tag
branch
from
August 29, 2023 05:00
14b381a to
4eb0bd1
Compare
erights
force-pushed
the
markm-tag-guards-2
branch
from
August 29, 2023 05:03
b13aa5b to
441a75d
Compare
erights
force-pushed
the
markm-abstract-guard-tag
branch
2 times, most recently
from
August 30, 2023 01:18
4e66d97 to
ca66ee9
Compare
erights
force-pushed
the
markm-tag-guards-2
branch
from
August 30, 2023 01:20
441a75d to
15b4ec9
Compare
erights
force-pushed
the
markm-abstract-guard-tag
branch
from
August 31, 2023 00:15
ca66ee9 to
dcf1071
Compare
erights
force-pushed
the
markm-tag-guards-2
branch
2 times, most recently
from
September 13, 2023 03:58
bb265ae to
4650264
Compare
This was referenced Sep 16, 2023
Contributor
Author
|
Agoric/agoric-sdk#8339 is where we're altering agoric-sdk to pave the way for this PR. |
erights
force-pushed
the
markm-tag-guards-2
branch
from
September 16, 2023 02:41
4650264 to
65e7934
Compare
erights
changed the base branch from
master
to
markm-interface-guard-type-param
September 16, 2023 02:42
erights
force-pushed
the
markm-tag-guards-2
branch
from
September 16, 2023 23:53
65e7934 to
c8305ef
Compare
erights
marked this pull request as ready for review
September 16, 2023 23:57
Contributor
Author
|
Hi @michaelfig , with Agoric/agoric-sdk#8339 merged, this is now ready for review. |
Contributor
Author
And with Agoric/agoric-sdk#8340 showing that agoric-sdk should now be compat with this PR |
erights
changed the title
michaelfig
approved these changes
Sep 17, 2023
michaelfig
left a comment
michaelfig
left a comment
Member
There was a problem hiding this comment.
Approval on the condition that you clearly decide whether to parameterize CopyTagged, or to leave that out of this PR.
erights
force-pushed
the
markm-tag-guards-2
branch
3 times, most recently
from
September 18, 2023 04:59
acb5a1c to
7cf5027
Compare
erights
force-pushed
the
markm-tag-guards-2
branch
from
September 18, 2023 05:03
7cf5027 to
25ded7a
Compare
This was referenced Feb 7, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staged on #1771
Make guards a distinct category of taggeds, on par with matchers.