Conversation
Also rename *Dispatch classes to *Transport and added aliases
|
Hmmm, not sure what's going on here, all checks are "cancelled" and there's no log at all so I guess I'll try again later 🤷♂️ |
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Fab yup! A few notes. Looking great. 👍
|
Looks like a linter failure on import sorting... https://github.com/encode/httpx/pull/963/checks?check_run_id=693477366 |
florimondmanca
left a comment
florimondmanca
left a comment
There was a problem hiding this comment.
Nice!
I assume the docs would need updating too - we're still using the Dispatch phrasing there as of the current state of this PR. Do we want to update it in this PR or as a follow-up?
Co-authored-by: Florimond Manca <[email protected]>
Probably best to change the docs now, there's quite a few code snippets using |
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
I'm happy with this whenever you are! Fantastic bit of work and really keen to see this land!
|
Great, once everyone's happy let's get this in as it is. Couple of follow ups I can think of, which I'll open individual issues for. |
|
Thanks all! 🎉 |
4 participants
Closes #768
I did somedispatch > transportrenaming but did not rename the_dispatchpackage and the*Dispatchclasses in it. I considered renaming the package to_transportsand all classes to*Transportwith*Dispatchaliases but thought it might be better to check first.Edit: Pipelines failed for some reason so I went for it while I gave GH actions some time to sort themselves out.