Move utility functions from _utils.py to _client.py#3389
Merged
lovelydinosaur merged 2 commits intoencode:masterfrom Nov 15, 2024
Merged
Move utility functions from _utils.py to _client.py#3389lovelydinosaur merged 2 commits intoencode:masterfrom
lovelydinosaur merged 2 commits intoencode:masterfrom
Conversation
RafaelWO
force-pushed
the
change/move-utils-to-client
branch
from
acf4ca6 to
53ed14e
Compare
Contributor
Author
|
I am not sure whether we should also move the class |
Contributor
|
Ah this is an interesting one. I'm going to suggest leaving the following in
We'll likely be able to remove them entirely due to a different piece of incoming refactoring, tho will treat that seperately. |
The following functions are moved because they are only used in _client.py * port_or_default * same_origin * is_https_redirect Related tests are also moved accordingly.
RafaelWO
force-pushed
the
change/move-utils-to-client
branch
from
53ed14e to
c36f07d
Compare
Contributor
Author
|
@tomchristie, I updated the PR accordingly 🙂 |
lovelydinosaur
approved these changes
Nov 15, 2024
Contributor
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Thanks, yes. Neatly done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #3381
This PR moves the following remaining utility functions from
_utils.pyto_client.pythat are only used in_client.py:port_or_defaultsame_originis_https_redirectRelated tests are also moved accordingly (to
tests/client/test_headers.py)Checklist