Merged
Conversation
T-256
approved these changes
Jul 23, 2024
| URLTypes, | ||
| VerifyTypes, | ||
| ) | ||
| from ._urls import URL |
Contributor
There was a problem hiding this comment.
could it be under typing.TYPE_CHECKING?
Contributor
Author
There was a problem hiding this comment.
I'd only use that if it was required to avoid a cyclical dependency.
Contributor
Author
|
Build failures addressed in #3246 |
zanieb
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/encode/httpx/issues/3176#issuecomment-2068231852
Our public methods currently include a shortcut type
URLTypes, which is not public API.This refactoring removes the shortcut type in favor of explicit typing.
There are also other similar cases, tho one this is an easy refactoring to demonstrate.