Skip to content

Comments

Add URL parsing tests from WHATWG#3188

Merged
lovelydinosaur merged 9 commits intomasterfrom
whatwg-tests
Jun 13, 2024
Merged

Add URL parsing tests from WHATWG#3188
lovelydinosaur merged 9 commits intomasterfrom
whatwg-tests

Conversation

@lovelydinosaur
Copy link
Contributor

@lovelydinosaur lovelydinosaur commented May 3, 2024

Add 563 URL parsing test cases from https://url.spec.whatwg.org/

Test cases are from...

TODO:

  • We've got a private import here, which we're avoiding in all our other tests case.
  • Add username/password checks.
  • We've two failing cases here.

Reminder to self follow-ups:

  • Comparison of WHATWG percent-escape set vs. chrome percent-escape set.
  • Exceptions for invalid domain names. *

* eg. see this comment for useful context

@lovelydinosaur lovelydinosaur marked this pull request as ready for review May 3, 2024 09:48
@lovelydinosaur
Copy link
Contributor Author

Not complete, but suitable for preliminary review.

@lovelydinosaur lovelydinosaur added the user-experience Ensuring that users have a good experience using the library label May 3, 2024
@lovelydinosaur lovelydinosaur requested a review from a team May 17, 2024 17:29
@lovelydinosaur
Copy link
Contributor Author

Thanks @karpetrosyan. Let's pass on the initial TODO items here, more of a priority to just get this in.

@lovelydinosaur lovelydinosaur merged commit db9072f into master Jun 13, 2024
@lovelydinosaur lovelydinosaur deleted the whatwg-tests branch June 13, 2024 13:46
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user-experience Ensuring that users have a good experience using the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants