Drop HTML line breaks on long headers in browsable API#9438
Merged
Conversation
auvipy
approved these changes
Jun 15, 2024
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
there was some merge conflicts, so I tried to fix them
auvipy
requested changes
Jun 15, 2024
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
may be we need to remove related tests as well?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
browniebroke
changed the title
browniebroke
approved these changes
Apr 27, 2025
auvipy
approved these changes
Apr 28, 2025
Contributor
|
This probably shouldn't have been in a patch level release (78e9707 is in 3.16.1, but not in 3.16.0) because customized DRF templates broke as the filter is no longer a thing. (Or, at least, the release notes for 3.16.1 should note it as a possibly breaking change, not as a bug fix.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #777
We don't really need to add line breaks
<br>in the browsable API on long headers. They render fine in the browser as-is.Superseeds fix in #9435 dealing with possible XSS against the browsable API.