Provide tests for hashing of OperandHolder#9437
Merged
auvipy merged 1 commit intoencode:masterfrom Jun 15, 2024
Merged
Conversation
auvipy
approved these changes
Jun 15, 2024
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
thanks for the followup contribution!
| assert hasperm is False | ||
|
|
||
| def test_operand_holder_is_hashable(self): | ||
| assert hash((permissions.IsAuthenticated & permissions.IsAdminUser)) |
Collaborator
There was a problem hiding this comment.
May fail if hash returns zero. The proper check would be that no exception is thrown. (E.g., via >= 0)
Comment on lines
+769
to
+772
| filtered_permissions = [ | ||
| perm for perm | ||
| in dict.fromkeys(unfiltered_permissions) | ||
| ] |
Collaborator
There was a problem hiding this comment.
filtered_permissions = list(dict.fromkeys(unfiltered_permissions))
Contributor
Author
|
@peterthomassen Should I open PR for these fixes? |
Collaborator
|
I don't think so; just trying to enable the community to learn from each other! :-) Thanks for the tests, I like how they are set up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide tests for #9417 according to comment