Skip to content

Cleanup#9393

Merged
peterthomassen merged 9 commits intomasterfrom
20240426_requirements
Apr 30, 2024
Merged

Cleanup#9393
peterthomassen merged 9 commits intomasterfrom
20240426_requirements

Conversation

@peterthomassen
Copy link
Collaborator

@peterthomassen peterthomassen commented Apr 26, 2024 •
edited
Loading

As discussed, this removes support for Django < 4.2 and Python < 3.8.

Further changes:

  • code cleanup
  • docs updates
  • dependency bumps
  • remove Windows line endings

@peterthomassen peterthomassen force-pushed the 20240426_requirements branch from 95b39d8 to 1468873 Compare April 26, 2024 14:01
@peterthomassen peterthomassen marked this pull request as ready for review April 26, 2024 14:10
@peterthomassen peterthomassen marked this pull request as draft April 26, 2024 14:17
@peterthomassen peterthomassen force-pushed the 20240426_requirements branch from 1468873 to da15cad Compare April 26, 2024 15:09
@peterthomassen peterthomassen marked this pull request as ready for review April 26, 2024 15:09
@peterthomassen peterthomassen force-pushed the 20240426_requirements branch 3 times, most recently from 8fb2a11 to 8030a12 Compare April 26, 2024 16:05
@peterthomassen peterthomassen changed the title 20240426 requirements Cleanup Apr 26, 2024
@peterthomassen
Copy link
Collaborator Author

peterthomassen commented Apr 26, 2024

This has gotten a little larger due to the last commit, but don't get scared, it's just whitespace changes ;-) Ready for review.

@auvipy auvipy self-requested a review April 27, 2024 05:32
lovelydinosaur
lovelydinosaur reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks.

but don't get scared, it's just whitespace changes

In general let's try to isolate changes as much as possible. The easier it is to review, the less likely we are to have sneaky errors creeping in. 😅

@peterthomassen peterthomassen force-pushed the 20240426_requirements branch from 2c49951 to 9d4ed05 Compare April 30, 2024 16:28
@peterthomassen peterthomassen merged commit 9d4ed05 into master Apr 30, 2024
@peterthomassen peterthomassen deleted the 20240426_requirements branch April 30, 2024 16:29
@peterthomassen
Copy link
Collaborator Author

peterthomassen commented May 30, 2024

@tomchristie It looks like the docs changes from this PR have not been deployed on https://www.django-rest-framework.org/. How is that kicked off?

@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented May 30, 2024

Currently we push docs changes as part of releases.

@lovelydinosaur lovelydinosaur mentioned this pull request Jun 14, 2024
Merged
@gsnider2195 gsnider2195 mentioned this pull request Jun 21, 2024
Merged
1 task
@AlvaroVega AlvaroVega mentioned this pull request Jun 27, 2024
Closed
@AlvaroVega
Copy link
Contributor

AlvaroVega commented Jun 27, 2024

As discussed, this removes support for Django < 4.2 and Python < 3.8.

Maybe this should be included in release notes?

@peterthomassen
Copy link
Collaborator Author

peterthomassen commented Jun 27, 2024

Yes, probably. Sorry about that omission. Would you be able to create a PR?

@AlvaroVega
Copy link
Contributor

AlvaroVega commented Jun 27, 2024

Yes, probably. Sorry about that omission. Would you be able to create a PR?

Sure: #9451

@oharsta oharsta mentioned this pull request Jul 23, 2024
Closed
@mikemanger mikemanger mentioned this pull request Mar 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovelydinosaur lovelydinosaur lovelydinosaur approved these changes

@auvipy auvipy Awaiting requested review from auvipy

Assignees

No one assigned

Labels

Cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@peterthomassen @lovelydinosaur @AlvaroVega @browniebroke @auvipy @TomNewChao