Make inflection package truly optional#9303
Merged
tfranzel merged 2 commits intoencode:masterfrom Mar 18, 2024
Merged
Conversation
browniebroke
changed the title
inflection package truly optional
tfranzel
suggested changes
Mar 18, 2024
Contributor
There was a problem hiding this comment.
Actually I would handle it analog to uritemplate, which does a graceful import and then asserts on it missing during a call.
I don't like this because it is inconsistent with the other optional libs and also silently uses a slightly degraded implementation without anyone noticing.
I think it should be like this:
Member
Author
|
Fair enough |
Co-authored-by: T. Franzel <[email protected]>
tfranzel
approved these changes
Mar 18, 2024
Contributor
tfranzel
left a comment
tfranzel
left a comment
There was a problem hiding this comment.
awesome. thanks @browniebroke
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #9291
The 3.15 release started to use the
inflectionpackage (#8017), but this was neither added as a dependency from DRF nor properly documented.Since this is only needed for generating the OpenAPI schema (which is deprecated), I don't think it's worth introducing this package as a hard dependency, we can document it like
pyyamlanduritemplate.Since the former solution was
13 lines, perhaps we can use it as fallback wheninflectionisn't installed?