Closed
Conversation
3 tasks
Contributor
|
A test to ensure the correct behaviour will complete this PR, I wrote one in #9209 which could be added. |
|
Also, can you link this PR to that issue ( #9209 )? |
Contributor
|
@satayyeb could you please add the testcase from #9209 to ensure that this change resolves that issue? class StaticHTMLRendererErrorTests(URLPatternsTestCase):
class StaticErrorView(APIView):
renderer_classes = (StaticHTMLRenderer,)
def get(self, request, **kwargs):
raise exceptions.ValidationError('error')
urlpatterns = [path('error', StaticErrorView.as_view())]
def test_statis_renderer_with_api_exception(self):
response = self.client.get('/error') # this line raise a TypeError
assert response.status_code == 400The test is important to ensure that we do not fell into the same issue again. |
auvipy
requested changes
Jul 15, 2024
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
replaced by another PR with tests. thanks for the initial fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #9209
Fixes #9209
Description
According to this documentation, the
RequestContextshould havestatus_codeanddetailskeys. so I changed theget_template_contextfunction to set these keys in the context.