mitigate global dependency on inflection #8017#8781
Merged
auvipy merged 1 commit intoencode:masterfrom Nov 28, 2022
Merged
Conversation
auvipy
approved these changes
Nov 28, 2022
cweider
added a commit
to cweider/courtlistener
that referenced
this pull request
Aug 23, 2023
A dependency on encode/django-rest-framework#8017 and later made less obtrusive by encode/django-rest-framework#8781, but it did not eliminate it. Any usage of the schema generator must be done in an environment that includes this package.
cweider
added a commit
to cweider/courtlistener
that referenced
this pull request
Aug 23, 2023
A dependency on encode/django-rest-framework#8017 and later made less obtrusive by encode/django-rest-framework#8781, but it did not eliminate it. Any usage of the schema generator must be done in an environment that includes this package.
cweider
added a commit
to cweider/courtlistener
that referenced
this pull request
Aug 23, 2023
`django-rest-framework` has recieved several patches for CSP compatibility, but unfortunately these are not included in the latest release (3.14.0) and a new release cannot be expected for a while. As such, we must replace the semantically versioned PyPI reference with a reference to the latest commit on the master branch of the package's Git Repository that contains the changes that we need (do not use `master` since it could change in unexpected and incompatible ways). Included in this change is the `inflection` package, unfortunate dependency added by encode/django-rest-framework#8017 and later made less obtrusive by encode/django-rest-framework#8781, but it did not eliminate it. Any usage of the schema generator must be done in an environment that includes this package. Fixes: freelawproject#3020
cweider
added a commit
to cweider/courtlistener
that referenced
this pull request
Aug 23, 2023
`django-rest-framework` has recieved several patches for CSP compatibility, but unfortunately these are not included in the latest release (3.14.0) and a new release cannot be expected for a while. As such, we must replace the semantically versioned PyPI reference with a reference to the latest commit on the master branch of the package's Git Repository that contains the changes that we need (do not use `master` since it could change in unexpected and incompatible ways). Included in this change is the use of `inflection` for the OpenAPI spec's `operationIds`, an unfortunate dependency added by encode/django-rest-framework#8017 and later made less obtrusive by encode/django-rest-framework#8781. Any usage of the schema generator must be done in an environment that includes this package. Additionally, this new approach makes the generated `operationId` that was `listPersons` into `listPeople`. Thankfully, this is immaterial. Fixes: freelawproject#3020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8017 indirectly introduced a new hard dependency.
rest_framework.openapi.AutoSchemais imported in the default settings, which makes this a new dependency for nearly everyone. That is the reason why the builds are failing at the moment, as thetox -e basetarget does not install the optionals.So either we move that newly introduced import out of the main code path or DRF needs to gain that dependency in
setup.py, which would probably be excessive.